harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pavel Pervov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2746) [drlvm][EXPERIMENTAL]Optimized ld_interface_vtable.
Date Tue, 19 Dec 2006 11:10:22 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2746?page=comments#action_12459598 ] 
Pavel Pervov commented on HARMONY-2746:

I've reviewed updated patch. It generally looks ok.

The list of things I would fix:
1) Comment for added fields does not describe m_intf_table_<N> members, it only refers
to m_intf_<N>
2) Not sure why the fast path is under '#ifndef VM_STATS' preprocessing
3) All new fields must be initialized explicitly in Class::init_internals. memset at the beginning
of that method is erroneous and will be removed.

> [drlvm][EXPERIMENTAL]Optimized ld_interface_vtable.
> ---------------------------------------------------
>                 Key: HARMONY-2746
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2746
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Alex Astapchuk
>            Priority: Trivial
>         Attachments: 0001-drlvm-EXPERIMENTAL-Optimized-ld_interface_vtable.txt, intf1.diff
> Attached is a try to optimize ld_interface_vtable helper to make it faster.
> Note to commiters: please, do NOT commit it into the main trunk. 
> This is extremely experimental, and its effect need to be carefully measured. 

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message