Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 2032 invoked from network); 24 Nov 2006 12:15:25 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 24 Nov 2006 12:15:25 -0000 Received: (qmail 45767 invoked by uid 500); 24 Nov 2006 12:15:34 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 45750 invoked by uid 500); 24 Nov 2006 12:15:34 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 45741 invoked by uid 99); 24 Nov 2006 12:15:34 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Nov 2006 04:15:34 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO brutus.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Nov 2006 04:15:23 -0800 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 3CDD07141E4 for ; Fri, 24 Nov 2006 04:15:03 -0800 (PST) Message-ID: <6589343.1164370503246.JavaMail.jira@brutus> Date: Fri, 24 Nov 2006 04:15:03 -0800 (PST) From: "Alexey Varlamov (JIRA)" To: commits@harmony.apache.org Subject: [jira] Commented: (HARMONY-2294) [drlvm][kernel test] ObjectTest needs to be included back to test runs In-Reply-To: <8569808.1164359941978.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ http://issues.apache.org/jira/browse/HARMONY-2294?page=comments#action_12452430 ] Alexey Varlamov commented on HARMONY-2294: ------------------------------------------ Oh, I should take coffee break - there is crystal clear description above. Sorry. > [drlvm][kernel test] ObjectTest needs to be included back to test runs > ---------------------------------------------------------------------- > > Key: HARMONY-2294 > URL: http://issues.apache.org/jira/browse/HARMONY-2294 > Project: Harmony > Issue Type: Bug > Components: DRLVM > Reporter: Elena Semukhina > Assigned To: Alexey Varlamov > Attachments: ObjectTest_fix.patch > > > ObjectTest has been excluded from test runs some time ago. It occasionally failed on Windows on testWaitlongint() and testWait1() . > I ran this test iteratively on drlvm and RI and found out that it failed on both VMs in the same way and with appoximately equal frequency. > I fixed the test so that it passes on RI. The test passes on DRLVM too now. > 1) testWaitlongint(): When failed, it always reported that it waited 499 ms instead of 500. I allowed the test to accept 1 ms less waiting time. > 2) testWait1(): it reported that InterruptedException has not been thrown while the waiting thread was interrupted. Actually it failed very rarely (once per 1000 runs). I think this happens because the test does not correctly wait for the thread's run() method start. Fixed. > 3) I added a minor fix to thread_native_condvar.c so that nanoseconds are rounded up rather than down. > I ran the test iteratively on linux / Win XP / Win 2003 / jet, opt, int and have not seen a failure for a long time. The record is 4000 runs on Win 2003 / jet. > I think the test should be included back to test runs. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira