Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <33264229.1162501218466.JavaMail.root@brutus>
Date: Thu, 2 Nov 2006 13:00:18 -0800 (PST)
From: "weldon washburn (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-1558) Cleaning insides of Class.h header
In-Reply-To: <4932443.1159020802341.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-1558?page=comments#action_12446724 ] 
            
weldon washburn commented on HARMONY-1558:
------------------------------------------

I just now did an svn update on my linux box then tried to apply ...06-11-02...  It gave the following error messages:

classloader.cpp
Hunk #21 FAILED at 928

jit_runtime_support.cpp
Hunk #17 FAILED at 2022

vm_strings.cpp
Hunk #1 FAILED at 243

> Cleaning insides of Class.h header
> ----------------------------------
>
>                 Key: HARMONY-1558
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1558
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Pavel Pervov
>         Assigned To: weldon washburn
>         Attachments: class-h-r465551-2006-10-19.patch, class-h-r469088-06-11-02-all.patch, constant-pool-r450808-09-28.patch, constant_pool_to_r449950_09_26.patch, linux-fix-breaks-all.patch, splitting-class-h-constant-pool-r452474-10-03.patch, splitting-class-h-constant-pool-r453987-10-07.patch, splitting-class-h-constant-pool-r454420-10-09-fixed.patch, splitting-class-h-constant-pool-r454420-10-09.patch, splitting-class-h-r450808-09-28.patch, splitting-class-h.patch
>
>
> "I would like to work on cleaning the insides of Class.h header file.
>  
> This header is related to internal representation of java class inside the VM. Currently it contains all entities for internal class representation: class itself, constant pool, members (field, method), exceptions handler, vtable and so forth. 
>  
> First thing I would like to do is to split the file into a group of files, each of which would contain only one entity (and some closely related entities, if any). This would produce the following headers: 
> 1)       Class.h - constant pool and class
> 2)       vtable.h - vtable
> 3)       class_member.h - field and method entities descriptors, exception handler descriptor
> 4)       cci.h - code chunk entity (part of compiled method code)
>  
> Second thing to do is to throw away members (and other stuff), which are not used anymore and the only reason they are still there is history or they do not belong to these files.
>  
> Third thing to do is to make all these entities C++ objects. Currently, member variables of all listed entities are used arbitrarily throughout DRLVM code. I would like to regularize usage and, also, document internals of these entities."

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira