Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@harmony.apache.org
Message-ID: <32400988.1164372123018.JavaMail.jira@brutus>
Date: Fri, 24 Nov 2006 04:42:03 -0800 (PST)
From: "Alexey Varlamov (JIRA)" <jira@apache.org>
To: commits@harmony.apache.org
Subject: [jira] Commented: (HARMONY-2301) [luni] flawed
 SecurityManager.checkPackageAccess() impl
In-Reply-To: <5896814.1164364141918.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-2301?page=comments#action_12452439 ] 
            
Alexey Varlamov commented on HARMONY-2301:
------------------------------------------

Ways to fix 1+2:
1) do not cache;
2) add some notification mechanism to j.l.Security, which should track if particular property value is changed and let SecurityManager instance know.

My preference is for 1) until actual measurements can prove caching is useful here.

> [luni] flawed SecurityManager.checkPackageAccess() impl
> -------------------------------------------------------
>
>                 Key: HARMONY-2301
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2301
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey Varlamov
>
> There are several problems in the current implementation of j.l.SecurityManager.checkPackageAccess() method:
> 1) Dead-end caching of "package.access" property on the first use;
> 2) Thread-unsafe parsing to array of names: concurrent threads may fail with NPE accessing partially-filled array.
> 3) Incomplete name matching procedure, only works for subpackges.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira