Return-Path: Delivered-To: apmail-harmony-commits-archive@www.apache.org Received: (qmail 95540 invoked from network); 24 Nov 2006 11:47:47 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 24 Nov 2006 11:47:47 -0000 Received: (qmail 15561 invoked by uid 500); 24 Nov 2006 11:47:56 -0000 Delivered-To: apmail-harmony-commits-archive@harmony.apache.org Received: (qmail 15540 invoked by uid 500); 24 Nov 2006 11:47:56 -0000 Mailing-List: contact commits-help@harmony.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@harmony.apache.org Delivered-To: mailing list commits@harmony.apache.org Received: (qmail 15531 invoked by uid 99); 24 Nov 2006 11:47:56 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Nov 2006 03:47:56 -0800 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO eris.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Nov 2006 03:47:46 -0800 Received: by eris.apache.org (Postfix, from userid 65534) id DFD9F1A9846; Fri, 24 Nov 2006 03:47:10 -0800 (PST) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r478840 - /harmony/enhanced/classlib/trunk/modules/security/src/test/impl/java/org/apache/harmony/security/tests/provider/crypto/SHA1PRNG_SecureRandomTest.java Date: Fri, 24 Nov 2006 11:47:10 -0000 To: commits@harmony.apache.org From: mloenko@apache.org X-Mailer: svnmailer-1.1.0 Message-Id: <20061124114710.DFD9F1A9846@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: mloenko Date: Fri Nov 24 03:47:09 2006 New Revision: 478840 URL: http://svn.apache.org/viewvc?view=rev&rev=478840 Log: lower down probability of ONE MORE intermittent failure in the test see also HARMONY-2284 [classlib][drlvm][security] intermittent failures of security module tests Modified: harmony/enhanced/classlib/trunk/modules/security/src/test/impl/java/org/apache/harmony/security/tests/provider/crypto/SHA1PRNG_SecureRandomTest.java Modified: harmony/enhanced/classlib/trunk/modules/security/src/test/impl/java/org/apache/harmony/security/tests/provider/crypto/SHA1PRNG_SecureRandomTest.java URL: http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/security/src/test/impl/java/org/apache/harmony/security/tests/provider/crypto/SHA1PRNG_SecureRandomTest.java?view=diff&rev=478840&r1=478839&r2=478840 ============================================================================== --- harmony/enhanced/classlib/trunk/modules/security/src/test/impl/java/org/apache/harmony/security/tests/provider/crypto/SHA1PRNG_SecureRandomTest.java (original) +++ harmony/enhanced/classlib/trunk/modules/security/src/test/impl/java/org/apache/harmony/security/tests/provider/crypto/SHA1PRNG_SecureRandomTest.java Fri Nov 24 03:47:09 2006 @@ -194,7 +194,6 @@ SecureRandom sr1; // these are needed to test new SecureRandom objects in loop SecureRandom sr2; // - byte[] myBytes; byte[] myBytes1; byte[] myBytes2; @@ -222,7 +221,7 @@ } if ( flag ) { - // probability of false failure is 1.5*10^-5 per run + // probability of false failure is 1.5*10^-5 per run for i=1 or less for i > 1 fail("TESTING RANDOM NUMBER GENERATOR QUALITY: IGNORE THIS FAILURE IF INTERMITTENT :: i=" + i); } } @@ -265,14 +264,23 @@ myBytes1 = new byte[i]; myBytes2 = new byte[i]; + sr1.nextBytes(myBytes1); sr2.nextBytes(myBytes2); + for ( int j = 0; j < i; j++ ) { + flag &= myBytes1[j] == myBytes2[j]; + } + // check again to avoid intermittent failures + sr1.nextBytes(myBytes1); + sr2.nextBytes(myBytes2); for ( int j = 0; j < i; j++ ) { flag &= myBytes1[j] == myBytes2[j]; } + if ( flag ) { - fail("unexpected: myBytes1[] == myBytes2[] :: i=" + i); + // probability of false failure is 1.5*10^-5 per run for i=1 or less for i > 1 + fail("TESTING RANDOM NUMBER GENERATOR QUALITY: IGNORE THIS FAILURE IF INTERMITTENT :: i=" + i); } }