harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2217) [drlvm] Improve interrupt() implementation
Date Fri, 17 Nov 2006 06:25:41 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2217?page=comments#action_12450649 ] 
            
Alexey Varlamov commented on HARMONY-2217:
------------------------------------------

Just minor notice: the 0001-removed-interrupter-thread.patch misses removal of the interrupter
declaration.
Also, NO_COND_VARS scheme in thread_native_fat_monitor.c now looks invalidated - shouldn't
we drop it entirely?

> [drlvm] Improve interrupt() implementation
> ------------------------------------------
>
>                 Key: HARMONY-2217
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2217
>             Project: Harmony
>          Issue Type: Sub-task
>          Components: DRLVM
>            Reporter: Salikh Zakirov
>            Priority: Minor
>         Attachments: 0001-removed-interrupter-thread.patch, 0002-refactored-wait_count-to-be-modified-only-from-wait.patch,
0003-replaced-HyThread.monitor-with-HyThread.current_condition.patch
>
>
> This issue contains improvements of interrupt() implementation on top of H-1789-updated.patch
from HARMONY-1789:
> 0001-removed-interrupter-thread.patch replaces the auxiiliary interrupter thread with
direct call to hycond_notify_all(), since this call does not require the monitor to be held
> 0002-refactored-wait_count-to-be-modified-only-from-wait.patch fixes wait_count handling,
which is broken a bit by 0001 patch. IMHO, modifying wait_count outside of threads waiting
on the monitor was not correct in the first place.
> 0003-replaced-HyThread.monitor-with-HyThread.current_condition.patch further simplifies
interrupt() implementation by removing special case for a thread waiting on a monitor, since
it boils down to waiting on a conditional variable.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message