harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rana Dasgupta (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2154) port_CPUs_number returns incorrect information on EM64T in wow mode
Date Tue, 28 Nov 2006 14:48:23 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2154?page=comments#action_12453936 ] 
            
Rana Dasgupta commented on HARMONY-2154:
----------------------------------------

Thanks for catching the typo. The reason it escaped me when testing is that in this implementation,
the cores api delegates to the cpus api if not found. My mistake. I don't think the results
are foggy. GetLogicalProcessorInformation finds the number of cores or NUMA nodes or physical
packages, and expresses their relationship. So HT eg., will be reported as a shared relationship
with the main processor on the same core. Multicore machines will enumerate the number of
true cores. I think it's fine to hold back this portion till we have a use case, when we will
know what exactly we are looking for

> port_CPUs_number returns incorrect information on EM64T in wow mode
> -------------------------------------------------------------------
>
>                 Key: HARMONY-2154
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2154
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: msvc, Windows XP
>            Reporter: Rana Dasgupta
>         Assigned To: Alexey Varlamov
>         Attachments: platformapi.patch, platformapi2.patch
>
>
> port_CPUs_number uses GetSystemInfo which returns incorrect platform information in emulation
mode. This fix looks for GetNativeSystemInfo in the kernel and uses it if available; if not
uses GetSystemInfo. On native 64 bit mode GetNative SystemInfo delegates to GetSystemInfo.
This, and the way WOW redirection works, enables the correct api to be used in all 32 and
64 bit situations.
> The patch also adds an api port_Cores_number for core counting on 32 and 64 bit platforms.
This is a placeholder implementataion to be extended if we decide to access NUMA or related
information through this api.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message