harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Egor Pasko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1986) fix for bug in simplifier
Date Thu, 23 Nov 2006 05:40:03 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1986?page=comments#action_12452128 ] 
            
Egor Pasko commented on HARMONY-1986:
-------------------------------------

The fix (test_2.patch) is good, may commit!

tested on SUSE9 gcc-3.3.3 IA-32: jvmti, c-unit, smoke, kernel tests passed

Minor issues:
* Ivan, please, provide patches relative to working_vm in future (now it is relative to working_vm/vm/jitrino/src),
you can detect it by looking into the first line of the patch
* To apply cleanly you need to add an extra newline at the end of file (Ivan, please, check
how patches apply (via 'patch -p0 <your_patch.txt') if you edit them by hand)

thanks!

> fix for bug in simplifier
> -------------------------
>
>                 Key: HARMONY-1986
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1986
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Kollegov ivan
>         Assigned To: Gregory Shimansky
>            Priority: Minor
>         Attachments: test.patch, test_2.patch
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message