harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey A. Ivanov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1825) [classlib][swing] Some excluded tests pass
Date Thu, 02 Nov 2006 12:50:19 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1825?page=comments#action_12446591 ] 
            
Alexey A. Ivanov commented on HARMONY-1825:
-------------------------------------------

It shouldn't fail any way because text is measured in the test the same way it is measured
by PlainView. (It's a little more tricky in PlainView though but equivalent.)

My guess was that font metrics get changed (getPreferredSpan updates them if necessary), but
I was wrong here as well. However they shouldn't change since font of JTextArea couldn't change
on its own.
I ran along all the code of getPreferredSpan (incl. methods it calls), and I see no reason
why it could return other result rather than the expected one. 

But there's a reason -- no miracles; and it can lurk in lower layers than Swing is.

> [classlib][swing] Some excluded tests pass
> ------------------------------------------
>
>                 Key: HARMONY-1825
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1825
>             Project: Harmony
>          Issue Type: Bug
>          Components: build - test - ci
>            Reporter: Alexey A. Ivanov
>         Assigned To: Mark Hindess
>         Attachments: H1825-PlainViewTest.debug-not-to-commit.patch, H1825-PlainViewTest.debug-not-to-commit.patch,
H1825-test-unexclude.patch, H1825-test-unexclude.patch
>
>
> Several swing tests which are currently excluded from running pass successfully without
any modification.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message