harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory Shimansky (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-2268) [DRLVM] Fixing again reverted change in Runtime.java in kernel classes
Date Wed, 22 Nov 2006 18:12:03 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-2268?page=all ]

Gregory Shimansky resolved HARMONY-2268.

    Resolution: Fixed

I've changed close0 call in finalizer to call to close. I think it is better not only because
it is shorter, but because close is a synchronized method, and the changes to streamHandle
are done under synchronization.

Patch applied at 478267. Please check that it was applied as expected.

> [DRLVM] Fixing again reverted change in Runtime.java in kernel classes
> ----------------------------------------------------------------------
>                 Key: HARMONY-2268
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2268
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: All
>            Reporter: Ivan Volosyuk
>         Assigned To: Gregory Shimansky
>         Attachments: h2268.diff
> Reverted fix was to avoid closing file handle in finalize() method if it is already closed
by close().
> If we close the file descriptor twice we will close randomly opened file handle, which
have reused ours file handle. This leads to random crashes in different places.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message