harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "spark shen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2286) [classlib] [luni] EnumSet.writeReplace() is never used
Date Thu, 30 Nov 2006 03:34:22 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2286?page=comments#action_12454525 ] 
            
spark shen commented on HARMONY-2286:
-------------------------------------

I cited the following paragraph:
<cite>

>>Class java.util.EnumSet.SerializationProxy extends Object implements Serializable

>>serialVersionUID: 362491234563181265L 
>>Serialization Methods 
>>readResolve
>>private Object readResolve()Serialized Fields 
>>elementType
>>Class<T> elementTypeThe element type of this enum set. 
>>elements
>>Enum<E extends Enum<E>>[] elementsThe elements contained in this enum
set.

<cite>

This paragraph lays below java.util.EnumMap->Serialized Form (It is odd that EnumSet does
not provide a Serialized Form to link to this paragraph directly)

Best regards

> [classlib] [luni] EnumSet.writeReplace() is never used
> ------------------------------------------------------
>
>                 Key: HARMONY-2286
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2286
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>            Priority: Minor
>         Attachments: lunipatch.txt
>
>
> I have been looking at some of the bugs found by Melody and one of them is that there's
an illegal cast in EnumSet.writeReplace() ("Impossible cast from java.lang.Object[] to java.lang.Enum[]
in java.util.EnumSet.writeReplace()").  I realised that this method is never used.  All instances
of EnumSet are subclasses (either MiniEnumSet or HugeEnumSet) and because writeReplace() has
private visibility it is not used by subclasses when they are serialized.
> On inspection I don't actually think the inner class EnumSet.SerializationProxy is needed
- I think serialization should work for EnumSet without it because it doesn't seem to have
any special behaviour.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message