harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ge...@apache.org
Subject svn commit: r471184 - /incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/InetAddress.java
Date Sat, 04 Nov 2006 13:42:33 GMT
Author: geirm
Date: Sat Nov  4 05:42:32 2006
New Revision: 471184

URL: http://svn.apache.org/viewvc?view=rev&rev=471184
Log:
We were leaking file descriptors - easily shown with 
test program in HARMONY-1830.  I believe this is right - 
I dug through the createSocket() and socketClose() calls (nice
naming symmetry, btw...) and I think this is the right
way to do it. (There are no docs I can find).  I hope someone
else reviews.

The test program in HARMONY-1830 now runs fine.

Modified:
    incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/InetAddress.java

Modified: incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/InetAddress.java
URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/InetAddress.java?view=diff&rev=471184&r1=471183&r2=471184
==============================================================================
--- incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/InetAddress.java
(original)
+++ incubator/harmony/enhanced/classlib/trunk/modules/luni/src/main/java/java/net/InetAddress.java
Sat Nov  4 05:42:32 2006
@@ -888,6 +888,9 @@
                 reached = true;
             }
         }
+        
+        NETIMPL.socketClose(fd);
+        
         return reached;
     }
 



Mime
View raw message