harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey A. Ivanov (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-2253) [classlib][swing] unit test fails: j.s.text.ParagraphViewTest
Date Tue, 21 Nov 2006 13:48:03 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-2253?page=all ]

Alexey A. Ivanov updated HARMONY-2253:
--------------------------------------

    Attachment: H2253-o.a.h.x.swing.Utilities.patch

The test failure was caused by incorrect handling of negative numbers in org.apache.harmony.x.swing.Utilities.safeIntSum().
I've updated it to handle negative values of the second argument, updated the javadoc and
added TODO to properly handle negative values (i.e. to prevent underflow).

I've also generified the code so that it compiles without warnings.

> [classlib][swing] unit test fails: j.s.text.ParagraphViewTest
> -------------------------------------------------------------
>
>                 Key: HARMONY-2253
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2253
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Alexey A. Ivanov
>         Attachments: H2253-o.a.h.x.swing.Utilities.patch
>
>
> Unit test javax.swing.text.ParagraphViewTest fails:
> testSetLineSpacingNegative(javax.swing.text.ParagraphViewTest)
> junit.framework.AssertionFailedError: expected:<0> but was:<15>
> 	at javax.swing.text.ParagraphViewTest.testSetLineSpacingNegative(ParagraphViewTest.java:683)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message