harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "spark shen (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2286) [classlib] [luni] EnumSet.writeReplace() is never used
Date Mon, 27 Nov 2006 16:38:22 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2286?page=comments#action_12453637 ] 
            
spark shen commented on HARMONY-2286:
-------------------------------------

SerializationProxy is documented in spec 'serialization form'. So to keep serialization compatibility,
this inner class is needed. 

> [classlib] [luni] EnumSet.writeReplace() is never used
> ------------------------------------------------------
>
>                 Key: HARMONY-2286
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2286
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Sian January
>            Priority: Minor
>         Attachments: lunipatch.txt
>
>
> I have been looking at some of the bugs found by Melody and one of them is that there's
an illegal cast in EnumSet.writeReplace() ("Impossible cast from java.lang.Object[] to java.lang.Enum[]
in java.util.EnumSet.writeReplace()").  I realised that this method is never used.  All instances
of EnumSet are subclasses (either MiniEnumSet or HugeEnumSet) and because writeReplace() has
private visibility it is not used by subclasses when they are serialized.
> On inspection I don't actually think the inner class EnumSet.SerializationProxy is needed
- I think serialization should work for EnumSet without it because it doesn't seem to have
any special behaviour.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message