harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Egor Pasko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-2207) [drlvm][ipf] auto constants folding/propagation and few minor low level optimizations
Date Fri, 17 Nov 2006 12:57:40 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-2207?page=comments#action_12450726 ] 
            
Egor Pasko commented on HARMONY-2207:
-------------------------------------

Igor, the patch is good and interesting reading. Please, ipdate it with tabs
converted to spaces (you have them in  Emitter::bundling())

There are some minor questions that I want to ask:

(1)
+    // 6 pass: code optimizing
+    // TODO: delete if block
+    if (false && LOG_ON) {
+        checkForDualIssueBundles();
+    }
+
Did you put these lines by mistake or they have some hidden meaning? please
comment on it.

(2)
Why do you always use IPF_ASSERT? that is:
#define IPF_ASSERT(condition) if (VERIFY_ON && !(condition)) { IPF_ERR << (#condition)
<< endl; }
why not wipe this redundant "if" out in release mode? "if"s are not fast on IPF :)

(3)
Why do you add f0 as an operand to the FP multiply instruction? isn't it
redundant?

(4)
Are you going to transform STL containers to MemoryManager based ones soon?
for example:
vm/jitrino/src/codegenerator/ipf/include/IpfType.h:209:typedef bitset< NUM_G_REG > 
        RegBitSet;

(5)
what is the patch queue that I need to apply to build on IPF? :)

> [drlvm][ipf] auto constants folding/propagation and few minor low level optimizations
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-2207
>                 URL: http://issues.apache.org/jira/browse/HARMONY-2207
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>         Environment: SUSE 9, ia64
>            Reporter: Igor V Chebykin
>         Assigned To: Alexey Varlamov
>         Attachments: patch.txt
>
>
> IpfCodeLayouter.cpp
>     completers for branches changed
> IpfOpndManager.h
> IpfOpndManager.cpp
>     imm for heapbase and vtablebase added
> IpfCfg.h
>     isGReg() and isFReg() functions added
> IpfEmitter.h
> IpfType.h
>     IPF_ASSERT minor changes
>     isGReg() and isFReg() added
> IpfInstCodeSelector.cpp
>     auto constant folding/propagation added
>     completers for branches changed
>     converting float to int32 optimized
>     register allocation optimized
> IpfEmitter.cpp
>     ignored pseudo-insts removing added before emitting
>     bundling changed
> IpfVerifier.cpp
>     minor change for debugging support
> IpfEncoder.cpp
>     bug fixed
> IpfType.cpp
>     constant folding/propagation support added
> IpfCodeGenerator.cpp
>     minor change
>     isGReg() and isFReg() added

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message