[ http://issues.apache.org/jira/browse/HARMONY-2000?page=comments#action_12448592 ]
weldon washburn commented on HARMONY-2000:
------------------------------------------
comments on native_sources_cleanup_upd.patch
1)
I glanced at this patch. It looks like these mods should have minor impact on stability.
Its mostly cleaning up C struct malloc/free. Please confirm.
2)
The big comment in mem_alloc.h is vague. It would be good to make it clearer. It starts
with, "
+// PoolManager contains 2 lists of PoolDescriptors (memory chunks):
+// active and passive. Active chunks can be reused in future memory allocations
3)
I tried to apply this patch to current svn HEAD. It fails on 3 or 4 files. Please fix.
> Class unloading support
> -----------------------
>
> Key: HARMONY-2000
> URL: http://issues.apache.org/jira/browse/HARMONY-2000
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Environment: IA32 system only (no compressed mode support yet), gcv4.
> Reporter: Aleksey Ignatenko
> Assigned To: weldon washburn
> Attachments: auto_unloading.patch, auto_unloading_upd.patch, class_unloading_cvn_v3.patch,
class_unloading_cvn_v3_upd.patch, gc_pinned_alloc_implemented.patch, gcv4.xml, gcv41_class_unloading.diff,
jvmti_iterate_workaround.diff, native_sources_cleanup.patch, native_sources_cleanup_upd.patch,
Test_unloading_native_lib.zip
>
>
> DRLVM Class unloading support. There 2 parts in the patch: 1. Cleaning native sources
for unloaded classes. 2. Introduction of class unloading.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
|