harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Petrenko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1994) [classlib][pack200] Can now write constant fields in interfaces :-)
Date Sat, 04 Nov 2006 15:50:17 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1994?page=comments#action_12447155 ] 
            
Alexey Petrenko commented on HARMONY-1994:
------------------------------------------

I agree with Paulex. Anyway additional patch elements are not a problem if you are using command
line patch (as I do :). -p option helps.

It would also be great to have a list of added and removed files. As it specified in the"Good
issue resolution guideline". :)

I got another problem with the patch. The following files are mentioned in the patch but they
are missed in the repository:
src/main/java/org/apache/harmony/archive/internal/pack200/bytecode/ConstantPoolEntry.java
src/main/java/org/apache/harmony/archive/internal/pack200/bytecode/ClassFile.java
src/main/java/org/apache/harmony/archive/internal/pack200/bytecode/ClassFileEntry.java
src/main/java/org/apache/harmony/archive/internal/pack200/bytecode/ClassConstantPool.java

It seems that you've moved these files from src/main/java/org/apache/harmony/archive/internal/pack200
directory but your patch does not have this info...

Can you please fix the patch?

> [classlib][pack200] Can now write constant fields in interfaces :-)
> -------------------------------------------------------------------
>
>                 Key: HARMONY-1994
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1994
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Alex Blewitt
>            Priority: Trivial
>         Attachments: pack200-test.patch, pack200.patch
>
>
> Continued work on pack200 code. Refactored all inner classes (ConstantPoolEntry/ClassFileEntry)
into separate bytecode package, wrote some tests (not fully complete). Updated segment parsing
to build that, and we can now reconstitute interfaces that have integer hard-coded constants
stored, as well as fields.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message