Return-Path: Delivered-To: apmail-incubator-harmony-commits-archive@www.apache.org Received: (qmail 45301 invoked from network); 7 Oct 2006 19:33:39 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 7 Oct 2006 19:33:39 -0000 Received: (qmail 20611 invoked by uid 500); 7 Oct 2006 19:33:39 -0000 Delivered-To: apmail-incubator-harmony-commits-archive@incubator.apache.org Received: (qmail 20581 invoked by uid 500); 7 Oct 2006 19:33:39 -0000 Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-commits@incubator.apache.org Received: (qmail 20570 invoked by uid 99); 7 Oct 2006 19:33:39 -0000 Received: from idunn.apache.osuosl.org (HELO idunn.apache.osuosl.org) (140.211.166.84) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Oct 2006 12:33:39 -0700 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= Received: from [209.237.227.198] ([209.237.227.198:34545] helo=brutus.apache.org) by idunn.apache.osuosl.org (ecelerity 2.1.1.8 r(12930)) with ESMTP id F9/68-09076-11108254 for ; Sat, 07 Oct 2006 12:33:37 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 40F097141B8 for ; Sat, 7 Oct 2006 12:33:21 -0700 (PDT) Message-ID: <7931344.1160249601263.JavaMail.root@brutus> Date: Sat, 7 Oct 2006 12:33:21 -0700 (PDT) From: "Pavel Pervov (JIRA)" To: harmony-commits@incubator.apache.org Subject: [jira] Updated: (HARMONY-1558) Cleaning insides of Class.h header In-Reply-To: <4932443.1159020802341.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/HARMONY-1558?page=all ] Pavel Pervov updated HARMONY-1558: ---------------------------------- Attachment: splitting-class-h-constant-pool-r453987-10-07.patch Strangely, gcc 3.4.5 can't compile sizeof(((Type*)NULL)->field) but gcc 4.0.2 can for the following case: struct Foo {}; struct Type { Foo foo; int field; }; > Cleaning insides of Class.h header > ---------------------------------- > > Key: HARMONY-1558 > URL: http://issues.apache.org/jira/browse/HARMONY-1558 > Project: Harmony > Issue Type: Improvement > Components: DRLVM > Reporter: Pavel Pervov > Assigned To: weldon washburn > Attachments: constant-pool-r450808-09-28.patch, constant_pool_to_r449950_09_26.patch, splitting-class-h-constant-pool-r452474-10-03.patch, splitting-class-h-constant-pool-r453987-10-07.patch, splitting-class-h-r450808-09-28.patch, splitting-class-h.patch > > > "I would like to work on cleaning the insides of Class.h header file. > > This header is related to internal representation of java class inside the VM. Currently it contains all entities for internal class representation: class itself, constant pool, members (field, method), exceptions handler, vtable and so forth. > > First thing I would like to do is to split the file into a group of files, each of which would contain only one entity (and some closely related entities, if any). This would produce the following headers: > 1) Class.h - constant pool and class > 2) vtable.h - vtable > 3) class_member.h - field and method entities descriptors, exception handler descriptor > 4) cci.h - code chunk entity (part of compiled method code) > > Second thing to do is to throw away members (and other stuff), which are not used anymore and the only reason they are still there is history or they do not belong to these files. > > Third thing to do is to make all these entities C++ objects. Currently, member variables of all listed entities are used arbitrarily throughout DRLVM code. I would like to regularize usage and, also, document internals of these entities." -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira