Return-Path: Delivered-To: apmail-incubator-harmony-commits-archive@www.apache.org Received: (qmail 77782 invoked from network); 18 Oct 2006 14:47:32 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 18 Oct 2006 14:47:32 -0000 Received: (qmail 84889 invoked by uid 500); 18 Oct 2006 14:47:30 -0000 Delivered-To: apmail-incubator-harmony-commits-archive@incubator.apache.org Received: (qmail 84860 invoked by uid 500); 18 Oct 2006 14:47:30 -0000 Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-commits@incubator.apache.org Received: (qmail 84831 invoked by uid 99); 18 Oct 2006 14:47:30 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2006 07:47:30 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [209.237.227.198] (HELO brutus.apache.org) (209.237.227.198) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Oct 2006 07:47:29 -0700 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id D8FBA7142E4 for ; Wed, 18 Oct 2006 07:46:36 -0700 (PDT) Message-ID: <17512405.1161182796886.JavaMail.jira@brutus> Date: Wed, 18 Oct 2006 07:46:36 -0700 (PDT) From: "Alexei Zakharov (JIRA)" To: harmony-commits@incubator.apache.org Subject: [jira] Commented: (HARMONY-1611) [classlib][beans] refactoring of PersistenceDelegateTest In-Reply-To: <8189663.1159371833298.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N [ http://issues.apache.org/jira/browse/HARMONY-1611?page=comments#action_12443283 ] Alexei Zakharov commented on HARMONY-1611: ------------------------------------------ Everything is ok, thanks. > [classlib][beans] refactoring of PersistenceDelegateTest > -------------------------------------------------------- > > Key: HARMONY-1611 > URL: http://issues.apache.org/jira/browse/HARMONY-1611 > Project: Harmony > Issue Type: Bug > Components: Classlib > Environment: winXP > Reporter: Alexei Zakharov > Assigned To: Mikhail Loenko > Attachments: HY-1611_classlib.patch, HY-1611_PersistenceDelegateTest.patch > > > As it was decided in the mailing list [1] the tests from the org.apache.harmony.beans.tests.java.beans.PersistenceDelegateTest class must be refactored since they use the bad reverse engineers technique. The attached patch contains fixes for five tests: > testWriteObject_NormalMutatesToTrue > testWriteObject_NormalMutatesToFalse > testWriteObject_NullObject > testWriteObject_NullEncoder > testMutatesTo_Null > I will create a separate JIRA for remaining tests. > The old heavy calls to the CallVerificationStack class were replaced with much more lightweight mock object calls. Now all tests pass on RI but some still fail on Harmony. I will provide the patch for Harmony classlib code soon, the attached patch is for tests only. > [1] http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/%3c2c9597b90609150556r359ddebv192ced44be6248a1@mail.gmail.com%3e -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira