harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexei Zakharov (JIRA)" <j...@apache.org>
Subject [jira] Created: (HARMONY-1992) [classlib][beans] new fixes for DefaultPersistenceDelegate failures (3)
Date Fri, 27 Oct 2006 17:45:16 GMT
[classlib][beans] new fixes for DefaultPersistenceDelegate failures (3)
-----------------------------------------------------------------------

                 Key: HARMONY-1992
                 URL: http://issues.apache.org/jira/browse/HARMONY-1992
             Project: Harmony
          Issue Type: Improvement
          Components: Classlib
         Environment: winXP
            Reporter: Alexei Zakharov


The attached patch fixes the following tests from the org.apache.harmony.beans.tests.java.beans.DefaultPersistenceDelegateTest
class:

testInitialize_NormalBeanInfo
testInitialize_SameInstance
testInitialize_TransientProperty
testInitialize_NullEncoder
These tests were refactored. All references to CallVerificationStack class were removed (as
it was decided in the mailing list) and replaced with much more lightweight technique. During
enabling of these tests I found that RI uses a bit different model for DefaultPersistenceDelegate#initialize()
(and probably for other methods) and stores a lot of extra statements to the output stream.
From the spec point of view these statements are not really required. I've decided to keep
the current model for now and just hack the tests to satisfy both models (ours and RI's).
However, if during enabling of some real applications it turns out that we need so follow
the RI's model I promise to get back to this.

testInitialize_NotRegularGetter
Deleted since the logic is the same with the testInitialize_NormalBeanInfo test

testInitizalize_Normal
The test was reworked, extra test logic was added.

Now all tests pass on Harmony. So we can remove DefaultPersistenceDelegateTest from exclude
list. BTW, there are still two valid failures on RI.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message