harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1651) [drlvm][kernel] Some issues in j.l.Package implementation
Date Wed, 04 Oct 2006 10:22:21 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1651?page=comments#action_12439788 ] 
Alexey Varlamov commented on HARMONY-1651:

Why NPE for desiredVersion but NFE for specVersion?
Specification says "NumberFormatException - if the desired or current version is not of the
correct dotted form"
I suggest simply add in the beginning:

if (desiredVersion == null || specVersion == null) {
   throw new NumberFormatException("Empty version string"); 

> [drlvm][kernel] Some issues in j.l.Package implementation
> ---------------------------------------------------------
>                 Key: HARMONY-1651
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1651
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Serguei Zapreyev
>         Attachments: H1651.jlP_impl.patch, Test1.java, Test2.java, Test3.java
> Some defects in Package impl: 
> - Package.isCompatibleWith("") throws NPE instead of NumberFormatException (Teast1).

>   Throwing the NumberFormatException as demanded resolves the issue. 
> - java.lang.Package.isSealed((java.net.URL)null) should throw NPE (Teast2). 
>   Throwing the NulPointerException as demanded resolves the issue. 
> - pakage info inaccessibility (DRLVM does not provide access to information describing
a package.)   
>   (Teast3). 
>   Changing the dot-separated Manifest entry name form to slash-separated one resolves
the issue.
> I'm going to attach the corresponding patch to fix the issues and the corresponding tests.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message