harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "weldon washburn (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1677) [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
Date Thu, 05 Oct 2006 18:34:21 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1677?page=comments#action_12440206 ] 
            
weldon washburn commented on HARMONY-1677:
------------------------------------------

Mikhail,
Thanks.  I downloaded the patch and did a clean build.  All the regression tests work except
for 3 sign extend tests and, of course, the atomic CAS tests.

The AddressTest.toLong() might actually be working correctly.  The test may not be properly
constructed.  In any case, I recall this test passing on the previous version of JET.  The
test is:

   public static boolean toLong() {
        Address adr = Address.fromInt(0xffFFffFF);
        long lon = adr.toLong();
        System.out.print(" --- lon = " + Long.toHexString(lon) + "--- ");
        return lon == 0x00000000ffFFffFFL;
    }

ExtentTest.fromIntSignExtend() also needs to be looked at:

   public static boolean fromIntSignExtend()
    {
        boolean res = true;  //wjw is this test correct???
        //System.out.println("fromIntSignExtend " + Long.toHexString(Extent.fromIntSignExtend(0xBABA).toLong()
) );
        System.out.print(" --- 0xBABA = " + Long.toHexString(Extent.fromIntSignExtend(0xBABA).toLong()
) + " --- ");
        res &= Extent.fromIntSignExtend(0xBABA).toLong() ==     0xffFFffFFffFFBABAL;
        res &= Extent.fromIntSignExtend(0xffffffff).toLong() == 0xFFffFFffFFffFFffL;
        System.out.print(" --- 0xffFFffFF = " + Long.toHexString(Extent.fromIntSignExtend(0xffFFffFF).toLong()
) + " --- ");
        
        return res;
    }

And the same for WordTest:

    
    public static boolean fromIntSignExtend()
    {
        boolean res = true;  //wjw is this test correct???
        //System.out.println("fromIntSignExtend " + Long.toHexString(Extent.fromIntSignExtend(0xBABA).toLong()
) );
        System.out.print("--- 0xBABA =  " + Long.toHexString(Extent.fromIntSignExtend(0xBABA).toLong()
)  + " --- " );
        res &= Word.fromIntSignExtend(0xBABA).toLong() ==       0xffFFffFFffFFBABAL;
        System.out.print("--- 0xffFFffFF =  " + Long.toHexString(Extent.fromIntSignExtend(0xffFFffFF).toLong()
)  + " --- " );
        res &= Word.fromIntSignExtend(0xffffffff).toLong() ==   0xFFffFFffFFffFFffL;
        return res;
    }





> [drlvm][jitrino]MMTk-style magics implementation for Jitrino.JET compiler.
> --------------------------------------------------------------------------
>
>                 Key: HARMONY-1677
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1677
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Mikhail Fursov
>         Assigned To: weldon washburn
>         Attachments: magic_jet1.zip, magic_jet2.zip
>
>
> This JIRA contains  'org/vmmagic/unboxed/' package implementation for Jitrino.JET compiler

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message