harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey A. Ivanov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1892) [test][swing] j.s.filechooser.FileSystemViewTest prompts to insert disk into drive A:
Date Wed, 25 Oct 2006 12:12:22 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1892?page=comments#action_12444645 ] 
            
Alexey A. Ivanov commented on HARMONY-1892:
-------------------------------------------

Stepan, thank you for finding the root cause. I must have missed it while looking at the test.
But I have some corrections: file.deleteOnExit() is always safe because it is called on the
object created in setUp(). It is file.delete() from tearDown() that caused problems. It is
needed there to make sure any files created are removed from the system, because several tests
assign another object to the file field.

In regards to the fixes from HARMONY-1893, I'd prefer to modify the last assertion in testGetSystemDisplayName().
I'll prepare another patch.
And once again thank you for your great effort!

> [test][swing] j.s.filechooser.FileSystemViewTest prompts to insert disk into drive A:
> -------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1892
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1892
>             Project: Harmony
>          Issue Type: Bug
>          Components: build - test - ci
>         Environment: Windows
>            Reporter: Alexey A. Ivanov
>         Assigned To: Stepan Mishura
>         Attachments: H1892-FileSystemViewTest.patch
>
>
> When running tests, javax.swing.filechooser.FileSystemViewTest.testGetSystemDisplayName()
prompts to insert disk into drive A:. This popup dialog stops this test and it fails.
> When running this test from Eclipse, there's no dialog popped up.
> I suggest removing the last two lines from testGetSystemDisplayName() to avoid this popup
dialog. The problem lines are (85-86):
>         file = File.listRoots()[0];
>         assertNotSame(file.getName(), view.getSystemDisplayName(file));

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message