harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Serguei Zapreyev (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1651) [drlvm][kernel] Some issues in j.l.Package implementation
Date Wed, 04 Oct 2006 15:53:23 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1651?page=comments#action_12439872 ] 
            
Serguei Zapreyev commented on HARMONY-1651:
-------------------------------------------

Alexey, I have run the test cases like of 4227825:
<<<...>>>
        Package p = Object.class.getPackage();
        try{System.out.println(p.isCompatibleWith(""));System.out.println("test case #1 Failed");}catch(NumberFormatException
_){System.out.println("test case #1 passed");}
        try{System.out.println(p.isCompatibleWith("0...."));System.out.println("test case
#2 Failed");}catch(NumberFormatException _){System.out.println("test case #2 passed");}
        try{System.out.println(p.isCompatibleWith("2.-2"));System.out.println("test case #3
Failed");}catch(NumberFormatException _){System.out.println("test case #3 passed");}
<<<...>>>

They passed for the discussed patch:

szapreye@nstdrlel7:~> /usr/jdk1.5.0_06/jdk/jre/bin/java -showversion -cp /nfs/ins/proj/drl/coreapi/ZSS/my_tests
Test
java version "1.5.0_06"
Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0_06-b05)
Java HotSpot(TM) Server VM (build 1.5.0_06-b05, mixed mode)
 
test case #1 passed
test case #2 passed
test case #3 passed
szapreye@nstdrlel7:~> /nfs/ins/proj/drl/coreapi/ZSS/G57/trunk/working_vm/build/lnx_ia32_gcc_
debug/deploy/jre/bin/java -showversion -classpath /nfs/ins/proj/drl/coreapi/ZSS/my_tests Test
Apache Harmony Launcher : (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors,
as applicable.
java version "1.5.0" 
pre-alpha : not complete or compatible
svn = r451216, (Oct  4 2006), Linux/ia32/gcc 3.3.3, debug build
http://incubator.apache.org/harmony
test case #1 passed
test case #2 passed
test case #3 passed
szapreye@nstdrlel7:~> 


> [drlvm][kernel] Some issues in j.l.Package implementation
> ---------------------------------------------------------
>
>                 Key: HARMONY-1651
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1651
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Serguei Zapreyev
>         Attachments: H1651.jlP_impl.patch, Test1.java, Test2.java, Test3.java
>
>
> Some defects in Package impl: 
> - Package.isCompatibleWith("") throws NPE instead of NumberFormatException (Teast1).

>   Throwing the NumberFormatException as demanded resolves the issue. 
> - java.lang.Package.isSealed((java.net.URL)null) should throw NPE (Teast2). 
>   Throwing the NulPointerException as demanded resolves the issue. 
> - pakage info inaccessibility (DRLVM does not provide access to information describing
a package.)   
>   (Teast3). 
>   Changing the dot-separated Manifest entry name form to slash-separated one resolves
the issue.
> I'm going to attach the corresponding patch to fix the issues and the corresponding tests.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message