harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Egor Pasko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1754) [drlvm][jit] Refactoring of 'devirt' and 'unguard' optimizations in Jitrino.OPT
Date Tue, 17 Oct 2006 06:27:37 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1754?page=comments#action_12442806 ] 
            
Egor Pasko commented on HARMONY-1754:
-------------------------------------

comments:
* patch is great!
* more parameters is great! more opportunities for performance tuning we have
* self-doc for parameters would have also been good. I do not feel that a in-depth explanation
is needed, a hacker can look in the code to understand what parameters do. A simple listing
of available params would be enough. Mikhail, could you, please? 
* the code looks much cleaner and more profile-oriented, but I do not see the specific flaws
in the previous impl of unguard. Are they easy to understand?
* I do not like lines wider than 80 characters, but it's not a disaster, let it bee

> [drlvm][jit] Refactoring of  'devirt' and 'unguard' optimizations in Jitrino.OPT
> --------------------------------------------------------------------------------
>
>                 Key: HARMONY-1754
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1754
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Mikhail Fursov
>         Assigned To: Geir Magnusson Jr
>         Attachments: devirt.diff
>
>
> This patch contains the following changes:
> 1) All previously hardcoded parameters used by devirt and unguard optimization passes
could be set up from command line. 
> 2) Unguard pass is usable from now. Now it processes edge profile correctly. I hope we
add profile guided unguarding to the server path after this fix commited. It shows ~1-2% performance
improvement on some benchmarks.
> 3) Profile guided devirtualization of object (not interface) methods added.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message