harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Salikh Zakirov (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-1978) [drlvm][testing] gc.Free fails for me on SUSE9
Date Thu, 26 Oct 2006 14:12:17 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-1978?page=all ]

Salikh Zakirov updated HARMONY-1978:

    Attachment: gc.Free.1.patch

-1 to gc.Free.patch. Reasons:
(1) gc.Free.patch does not address any of the problems desribed above,
i.e. warning will still be printed together with PASSED message, and the warning message
is incorrect (there is nothing wrong with free space increasing in the face of heap resize).
(2) it makes test almost useless. Initially, test checked sanity of the value returned by
after the modification it checks only trivial object allocation.

I suggest another patch to fix the issue: gc.Free.1.patch.
It contains 2 modifications to address issues:
1) in case of FAILED message terminate the test
2) do not attempt to allocate more than 1/2 of the space reported as free. Limit is set to
free/4 as the allocation
is perfomed as geometry progression: 1+2+4+...
It still has an implementation assumption that GC will not resize the heap as long as less
than 1/2 of the
heap is free, which I consider reasonable (and passing on both DRLVM and RI)

> [drlvm][testing] gc.Free fails for me on SUSE9
> ----------------------------------------------
>                 Key: HARMONY-1978
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1978
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: ia32 SUSE9
>            Reporter: Evgueni Brevnov
>         Attachments: gc.Free.1.patch, gc.Free.patch
> gc.Free started to fail with the following log:
> FAILED, Amount of free memory increases
> FAILED, Amount of free memory increases
> With the help of Salikh and Ivan it was identified that the test is NOT QUITE CORRECT.
> The behavior depends on initial memory reserved by GC for java heap.
> The fix is in attach. Please review.
> Thanks
> Evgueni

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message