harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ge...@apache.org
Subject svn commit: r464715 - /incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/src/kernel_classes/javasrc/java/lang/Thread.java
Date Mon, 16 Oct 2006 23:07:54 GMT
Author: geirm
Date: Mon Oct 16 16:07:53 2006
New Revision: 464715

URL: http://svn.apache.org/viewvc?view=rev&rev=464715
Log:
HARMONY-1741

Classlib test org.apache.harmony.luni.tests.java.lang.ThreadTest.test_suspend() hangs

with the patch, the testcase included in JIRA passes.  We do have test failures in 
our kernel test, java.lang.ThreadTest, but I believe they were there before.

Ubuntu 6 - test case, ~kernel, smoke, c-unit


Modified:
    incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/src/kernel_classes/javasrc/java/lang/Thread.java

Modified: incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/src/kernel_classes/javasrc/java/lang/Thread.java
URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/src/kernel_classes/javasrc/java/lang/Thread.java?view=diff&rev=464715&r1=464714&r2=464715
==============================================================================
--- incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/src/kernel_classes/javasrc/java/lang/Thread.java
(original)
+++ incubator/harmony/enhanced/drlvm/trunk/vm/vmcore/src/kernel_classes/javasrc/java/lang/Thread.java
Mon Oct 16 16:07:53 2006
@@ -635,17 +635,18 @@
     }
 
     /**
+     *  Note that this is unsnchronized - the assumption is that
+     *  hythread does the synchronization for us
+     *  
      * @com.intel.drl.spec_ref
      */
     public final void resume() {
-        synchronized (lock) {
             checkAccess();
             int status = VMThreadManager.resume(this);
             if (status != VMThreadManager.TM_ERROR_NONE) {
                 throw new InternalError(
                     "Thread Manager internal error " + status);
             }
-        }
     }
 
     /**
@@ -818,17 +819,18 @@
     }
 
     /**
+     *  Note that this is unsnchronized - the assumption is that
+     *  hythread does the synchronization for us
+     *  
      * @com.intel.drl.spec_ref
      */
     public final void suspend() {
-        synchronized (lock) {
             checkAccess();
             int status = VMThreadManager.suspend(this);
             if (status != VMThreadManager.TM_ERROR_NONE) {
                 throw new InternalError(
                     "Thread Manager internal error " + status);
             }
-        }
     }
 
     /**



Mime
View raw message