harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "weldon washburn (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1558) Cleaning insides of Class.h header
Date Sun, 08 Oct 2006 03:00:21 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1558?page=comments#action_12440725 ] 
            
weldon washburn commented on HARMONY-1558:
------------------------------------------

I tried patch against recent svn HEAD.  Below are the error messages I got:

On windows the first few error messages are:

       [cc] org_apache_harmony_vm_VMDebug.cpp
       [cc] stop_the_world_root_set_enum.cpp
       [cc] mon_enter_exit.cpp
       [cc] C:\t_harmony\drlvm\trunk\vm\vmcore\src\thread\mon_enter_exit.cpp(85)
 : error C2027: use of undefined type 'CodeChunkInfo'
       [cc]         c:\t_harmony\drlvm\trunk\vm\vmcore\include\vm_core_types.h(4
0) : see declaration of 'CodeChunkInfo'
       [cc] C:\t_harmony\drlvm\trunk\vm\vmcore\src\thread\mon_enter_exit.cpp(85)
 : error C2227: left of '->get_method' must point to class/struct/union
       [cc] C:\t_harmony\drlvm\trunk\vm\vmcore\src\thread\mon_enter_exit.cpp(87)
 : error C2027: use of undefined type 'Method'
       [cc]         C:\t_harmony\drlvm\trunk\vm\include\open\types.h(202) : see
declaration of 'Method'

On Linux/gcc3.4.5 the very first error messages is:

Trunk/vm/vmcore/src/thread/mon_enter_exit.cpp:85: error: use of undefined type 'struct CodeChunkInfo'



> Cleaning insides of Class.h header
> ----------------------------------
>
>                 Key: HARMONY-1558
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1558
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>            Reporter: Pavel Pervov
>         Assigned To: weldon washburn
>         Attachments: constant-pool-r450808-09-28.patch, constant_pool_to_r449950_09_26.patch,
splitting-class-h-constant-pool-r452474-10-03.patch, splitting-class-h-constant-pool-r453987-10-07.patch,
splitting-class-h-r450808-09-28.patch, splitting-class-h.patch
>
>
> "I would like to work on cleaning the insides of Class.h header file.
>  
> This header is related to internal representation of java class inside the VM. Currently
it contains all entities for internal class representation: class itself, constant pool, members
(field, method), exceptions handler, vtable and so forth. 
>  
> First thing I would like to do is to split the file into a group of files, each of which
would contain only one entity (and some closely related entities, if any). This would produce
the following headers: 
> 1)       Class.h - constant pool and class
> 2)       vtable.h - vtable
> 3)       class_member.h - field and method entities descriptors, exception handler descriptor
> 4)       cci.h - code chunk entity (part of compiled method code)
>  
> Second thing to do is to throw away members (and other stuff), which are not used anymore
and the only reason they are still there is history or they do not belong to these files.
>  
> Third thing to do is to make all these entities C++ objects. Currently, member variables
of all listed entities are used arbitrarily throughout DRLVM code. I would like to regularize
usage and, also, document internals of these entities."

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message