harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Fursov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1898) write barrier for C/C++ based GCs in Jitrino.OPT
Date Wed, 18 Oct 2006 09:05:36 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1898?page=comments#action_12443207 ] 
Mikhail Fursov commented on HARMONY-1898:

I think the patch is excellent.
The only problem I've found is:  TABs in sources. 

> write barrier for C/C++ based GCs in Jitrino.OPT
> ------------------------------------------------
>                 Key: HARMONY-1898
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1898
>             Project: Harmony
>          Issue Type: Improvement
>          Components: DRLVM
>         Environment: Windows and Linux, IA32
>            Reporter: Yu-Nan He
>         Attachments: WB4C_OPT.patch
> Attached patch is an implementation of write barrier for C/C++ based GCs in Jitrino.OPT.
The patch lets OPT to call "gc_requires_barriers()" of GC to determine if it needs to insert
the write barrier code into the jitted code, so it doesn't impact current DRLVM/GC at all.
 It calls gc_heap_slot_write_ref( ) of GC module.
> To Apply this patch, please enter vm/ directory and patch it. You can pass '-Xem:opt'
to EM to use the OPT-only mode. In any other modes, you should be sure to open the JET write
barrier for C/C++ based GCs .
> This patch is based on revision 465123.
> Please review this patch and see if it's ready for commission. Thanks. We hope it can
be committed to Harmony soon.

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message