harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Khaschansky (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HARMONY-1965) [classlib][swing] javax.swing.JList.addSelectionInterval(int, int) doesn't throw IndexOutOfBoundsException if parameter < -1
Date Fri, 27 Oct 2006 14:42:18 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-1965?page=all ]

Oleg Khaschansky updated HARMONY-1965:
--------------------------------------

    Attachment: harmony-1965.patch

RI checks for -1 before doing anything, so these methods return before failing if -1 is passed.
I updated a patch to match this behavior. Also I'll attach an updated testcase.

There's another problem with insertIndexInterval behavior.
The following sequence will throw IAE on RI:
        DefaultListSelectionModel model = new DefaultListSelectionModel();
        model.addSelectionInterval(0, 3);
        model.insertIndexInterval(0, -2, true);
But the following will pass silently:
        DefaultListSelectionModel model = new DefaultListSelectionModel();
        model.insertIndexInterval(0, -2, true);
The behavior of insertIndexInterval on RI differs from other methods and seems to be inconsistent.
I suggest not to copy this behavior and throw IAE in both cases.

> [classlib][swing] javax.swing.JList.addSelectionInterval(int, int) doesn't throw IndexOutOfBoundsException
if parameter < -1
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1965
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1965
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Oleg Khaschansky
>         Assigned To: Stepan Mishura
>         Attachments: harmony-1965.patch, harmony-1965.patch, harmony-1965test.patch,
harmony-1965test1.patch
>
>
> javax.swing.JList.addSelectionInterval(int, int) doesn't throw IndexOutOfBoundsException
if parameter < -1
> javax.swing.JList.addSelectionInterval(int anchor,int lead)specification reads:
> IndexOutOfBoundsException - if either anchor or lead are less than -1
> The same is applicable to removeSelectionInterval and setSelectionInterval methods.
> Code for reproducing:
> import javax.swing.*;
> public class Test{ 
>     public static void main(String[] args) { 
>                 Object[] data = {"Icon", "Int", "trueitem3", "charsetitem4",
> "Color"};
>                 JList toRet = new JList(data);
>                 toRet.addSelectionInterval(1, -2);
>         System.out.println("PASSED"); 
>     }    
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message