harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Egor Pasko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1986) fix for bug in simplifier
Date Fri, 27 Oct 2006 11:30:36 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1986?page=comments#action_12445151 ] 
            
Egor Pasko commented on HARMONY-1986:
-------------------------------------

Ivan, 

please, look at the issues I found in your test.patch:
* it changes the license message incorrectly in FlowGraph.cpp
* it changes the svn_version_tag.h (which is bad)
   just remove the file, make 'svn up .../svn_version_tag.h', 'svn diff' again
   or edit the patch manually
* do not see the point in changes within jitrino.xml (it has nothing in common with any fix
in simplifier)
   probably you need them in the JIT testing framework, clean them up here too (another JIRA
issue is eager to see them:)

Is there any test that failed before your patch and passes after applying? It would be nice
to see it here too.
Plese, also explain the bug and the basic idea of your changes (Some assertions are commented
out, these should be clarified)

> fix for bug in simplifier
> -------------------------
>
>                 Key: HARMONY-1986
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1986
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Kollegov ivan
>            Priority: Minor
>         Attachments: test.patch
>
>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message