harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tim Ellison (JIRA)" <j...@apache.org>
Subject [jira] Closed: (HARMONY-1506) [classlib][beans] new fixes for DefaultPersistenceDelegateTest failures
Date Tue, 17 Oct 2006 10:26:36 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-1506?page=all ]

Tim Ellison closed HARMONY-1506.
--------------------------------


Verified by Alexei.


> [classlib][beans] new fixes for DefaultPersistenceDelegateTest failures
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-1506
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1506
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: winXP
>            Reporter: Alexei Zakharov
>         Assigned To: Tim Ellison
>         Attachments: DefaultPDTest-1506.patch, DefaultPDTest-1506_updated.patch
>
>
> The following tests from the org.apache.harmony.beans.tests.java.beans. DefaultPersistenceDelegateTest
are affected (enabled) by the attached patch.
> testInstantiate_NotRegularGetter
> Failed because the test was optimized for buggy RI behavior, see HARMONY-1503. The test
was corrected.
> testMutatesTo_NormalNoProperty
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> I have corrected the assertion about comparing two strings "test1" and "test2" because
> 1) DefaultPersisteceDelegate will never be called for comparing Strings in normal conditions.
It is the job of StringPersistenceDelegate.
> 2) I definitely cannot imagine the circumstances in which one String object "test1" can
"mutate" to another String object "test2". Strings are immutable. So IMHO there is completely
no sense in returning true from mutatesTo("test1", "test2").
> testMutatesTo_NormalWithPropertyNoEqualMethod
> testMutatesTo_NormalWithNullPropertyPublicEqualMethod
> testMutatesTo_NormalWithEmptyPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyPublicEqualMethod
> testMutatesTo_NormalWithPropertyProtectedEqualMethod
> I have corrected the style a little bit. In fact I don't see much sense in testing of
various types of visibility of the equals() method. But since somebody has written this already
I just keep it untouched. 
> testMutatesTo_Null
> Fails on RI also. The test was corrected. Now it passes on Harmony as well as on RI.
> Thanks.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message