harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1720) Classlib test org.apache.harmony.luni.tests.java.lang.ThreadTest.test_stop_subtest0 fails
Date Fri, 13 Oct 2006 06:10:36 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1720?page=comments#action_12441929 ] 
            
Alexey Varlamov commented on HARMONY-1720:
------------------------------------------

-1 to the suggested patch. 
1) It introduces race condition into stop(), i.e. the thread may start right after checking
"alive" status and thus will not ever stop.
2) It adds inconsistency between stop() and stop(Throwable).

Please consider some other solution. I tried to find similar issues in Sun's bugdatabase,
but in vain. I guess "alive" status should not affect this behaviour, it might be other issue.

> Classlib test org.apache.harmony.luni.tests.java.lang.ThreadTest.test_stop_subtest0 fails
> -----------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1720
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1720
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Elena Semukhina
>            Priority: Critical
>         Attachments: Harmony-1720_Thread.patch
>
>
> The test fails with the following assertion:
> test_stop_subtest0(org.apache.harmony.luni.tests.java.lang.ThreadTest)junit.fework.AssertionFailedError:
checkAccess called
> The test does not expect that security manager's checkAccess() method is called when
stopping a new thread which is not running yet.
> I think it is a compatibility issue. 
> The spec for Thread.stop() says:
> If there is a security manager installed, its checkAccess method is called with this
as its argument.
> RI does not call this method for a thread which does not run, and this seems reasonable.
> I suggest that drlvm would do the same.
> NOTE: to reproduce the bug you should comment out ThreadTest.test_suspend() which hangs
now. This issue is expected to be fixed with H-1519.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message