Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <9067248.1158864864171.JavaMail.jira@brutus>
Date: Thu, 21 Sep 2006 11:54:24 -0700 (PDT)
From: "Geir Magnusson Jr (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-1490) [drlvm] Fixes for SingleStep
 implementation. Corrected phase, state structure, addded m2n transition
In-Reply-To: <10405026.1158595202337.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-1490?page=comments#action_12436607 ] 
            
Geir Magnusson Jr commented on HARMONY-1490:
--------------------------------------------

Yep, and it still doesn't work.

I did apply Pavel's HARMONY-1507, and began to see something.  I'll therefore apply yours, and if nothing breaks, commit and move on to 1507 and the rest of the chain.


> [drlvm] Fixes for SingleStep implementation. Corrected phase, state structure, addded m2n transition
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1490
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1490
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Gregory Shimansky
>         Assigned To: Geir Magnusson Jr
>         Attachments: single-step-fixes.patch, test.zip
>
>
> I've created several bugfixes for SingleStep event implementation.
> It appears that keeping enabled flag in JVMTISingleStepState struct is not possible because it may be deallocated when thread finishes. So I decided that enabled flag should be the pointer to this struct itself.
> Another bugfix is that SingleStep shouldn't be sent in phases other than LIVE. This also fixes the problem when SingleStep is sent for VM startup and agent cannot use any JNI function yet.
> Another bugfix is for breakpoint. For JIT mode I've added an m2n transition to allow stack iterator to work correctly inside of breakpoint callback. Otherwise it didn't see the upper Java frames.
> On windows the test I am using still crashes when it finishes, but at least I can see SingleStep events coming to the agent.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira