Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <28122832.1158569123896.JavaMail.jira@brutus>
Date: Mon, 18 Sep 2006 01:45:23 -0700 (PDT)
From: "Anton Luht (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-839) [classlib][util]WeakHashMap(Map
 arg) throws NPE if arg.entrySet() returns null
In-Reply-To: <14492386.1152635369780.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-839?page=comments#action_12435430 ] 
            
Anton Luht commented on HARMONY-839:
------------------------------------

the patch applied correctly to svn = r447316 and solved problem with WeakHashMap and IdentityHashMap

> [classlib][util]WeakHashMap(Map arg) throws NPE if arg.entrySet() returns null
> ------------------------------------------------------------------------------
>
>                 Key: HARMONY-839
>                 URL: http://issues.apache.org/jira/browse/HARMONY-839
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>         Environment: Windows XP
>            Reporter: Anton Luht
>         Assigned To: Paulex Yang
>            Priority: Trivial
>         Attachments: harmony-839.diff, identity_hash_map_patch.txt, patch.txt
>
>
> VM + Classlib version 420749
> Problem:
> If we create a Map with entrySet() method that return null, WeakHashMap constructor with it won't throw NPE in RI but will in Harmony.
> Code to reproduce:
> import java.util.*;
> public class Test  {
>  public static void main (String[] args) {                 
>           Map localMap = new TestMap();
>           new WeakHashMap(localMap);
>     } 
> } 
> class TestMap implements Map {
>                         public void clear() {
>                                     return;
>                         }
>                         public boolean containsKey(Object p0) {
>                                     return false;
>                         }
>                         public boolean containsValue(Object p0) {
>                                     return false;
>                         }
>                         public Set entrySet() {
>                                     return null;
>                         }
>                         public boolean equals(Object p0) {
>                                     return false;
>                         }
>                         public Object get(Object p0) {
>                                     return null;
>                         }
>                         public int hashCode() {
>                                     return 0;
>                         }
>                         public boolean isEmpty() {
>                                     return false;
>                         }
>                         public Set keySet() {
>                                     return null;
>                         }
>                         public Object put(Object p0, Object p1) {
>                                     return null;
>                         }
>                         public void putAll(Map p0) {
>                                     return;
>                         }
>                         public Object remove(Object p0) {
>                                     return null;
>                         }
>                         public int size() {
>                                     return 0;
>                         }
>                         public Collection values() {
>                                     return null;
>                         }
>             }
> Output in RI: none
> Output in Harmony:
> java.lang.NullPointerException
>         at java.util.AbstractMap.putAll(AbstractMap.java:282)
>         at java.util.WeakHashMap.<init>(WeakHashMap.java:231)
>         at Test.main(Test.java:5)
> Please see the unit test for this issue + patch to fix it attached

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira