Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <26258828.1159328574908.JavaMail.jira@brutus>
Date: Tue, 26 Sep 2006 20:42:54 -0700 (PDT)
From: "Paulex Yang (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-1350) [classlib][html] The method
 j.s.t.h.p.ContentModel.first() returns a value in cases in which it should
 return null
In-Reply-To: <5473216.1156956503330.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-1350?page=comments#action_12438006 ] 
            
Paulex Yang commented on HARMONY-1350:
--------------------------------------

Miguel, thank you for the jira and patch, but the test case you provided still fail on my WinXP with your patch, did I miss something? or it depends on HARMONY-1272? 

> [classlib][html] The method j.s.t.h.p.ContentModel.first() returns a value in cases in which it should return null
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1350
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1350
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Miguel Montes
>         Assigned To: Paulex Yang
>         Attachments: ContentModel01.patch, ContentModel01.patch
>
>
> The class ContentModel is a representation of a restricted BNF expression, for instance, (meta & base). The method first() returns the element that MUST be next. In the previous example, there is no such element. Both, meta and base, can be next. With this content model the RI returns null, buth the implementation in harmony returns  'base'. The test code provided is different for both implementations, because the internal representations are also different (issue HARMONY-1272)
> ==============================java code for harmony ============================
> import java.io.IOException;
> import javax.swing.text.html.parser.*;
> public class TestContentModelHarmony {
> 	public static void main(String[] args) throws IOException {
> 		DTD dtd = DTD.getDTD("tmp");
>         ContentModel model1 = new ContentModel (dtd.getElement(2));
>         ContentModel model2 = new ContentModel (dtd.getElement(3));
>         ContentModel model = new ContentModel ('&', model1, model2);
> 		System.out.println("ContentModel: " + model+ " First: "+model.first());
> 	}
> }
> =============================java code for RI============================
> import java.io.IOException;
> import javax.swing.text.html.parser.*;
> public class TestContentModelSun {
> 	public static void main(String[] args) throws IOException {
> 		DTD dtd = DTD.getDTD("tmp");
> 		ContentModel model1 = new ContentModel(dtd.getElement(3));
> 		ContentModel model2 = new ContentModel(0, dtd.getElement(2), model1);
> 		ContentModel model = new ContentModel('&', model2);
> 		System.out.println("ContentModel: " + model+ " First: "+model.first());
> 	}
> }
> =====================================================================
> Output
> $ java -showversion TestContentModelSun
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> Java HotSpot(TM) Client VM (build 1.5.0-b64, mixed mode)
> ContentModel: (meta & base) First: null
> $/harmony-hdk-r431938/jdk/jre/bin/java -showversion TestContentModelHarmony
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r431938, (Aug 16 2006), Linux/ia32/gcc 3.4.6, release build
> http://incubator.apache.org/harmony
> ContentModel: META&BASE First: javax.swing.text.html.parser.Element[index=3,name=BASE,oStart=false,oEnd=false,inclusions=null,exclusions=null,type=19,content=null,atts=null,data=null]
> Attached is a patch

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira