Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <14076899.1159188051902.JavaMail.jira@brutus>
Date: Mon, 25 Sep 2006 05:40:51 -0700 (PDT)
From: "Denis Kishenko (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-1538) [classlib][awt] Successor of
 CubicCurve2D throws NPE in contains() if getBounds2D() returns null
In-Reply-To: <11909665.1158920621785.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-1538?page=comments#action_12437538 ] 
            
Denis Kishenko commented on HARMONY-1538:
-----------------------------------------

Reference to discussion
http://mail-archives.apache.org/mod_mbox/incubator-harmony-dev/200609.mbox/%3c834b3bd50609250457w38492bf4s4e2a52e038d03c9e@mail.gmail.com%3e


> [classlib][awt] Successor of CubicCurve2D throws NPE in contains() if getBounds2D() returns null
> ------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1538
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1538
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Denis Kishenko
>
> If successor of CubicCurve2D returns null instead of bounds then Harmony throws NPE while RI doesn't. Harmony use shape bounds getBounds2D() to implement contains() and intersects() methods but It seems like RI doesn't use bounds for this. 
> ============== Test.java =================
> import java.awt.Frame;
> import java.awt.Graphics;
> import java.awt.Graphics2D;
> import java.awt.geom.*;
> public class Test {     
>     static public void main(String[] args) { 
>            final CubicCurve2DImpl obj = new CubicCurve2DImpl(100, 100, 200, 200, 200, 100, 100, 200);
>            
>            Frame f = new Frame("Test") {
>                public void paint(Graphics g) {
>                    ((Graphics2D)g).draw(obj);
>                }
>            };
>            f.setSize(600, 400);
>            f.show();
>            
>           System.out.println("obj.contains="+obj.contains(0, 0));
>     }
> }
> class CubicCurve2DImpl extends java.awt.geom.CubicCurve2D.Double {
>                 public CubicCurve2DImpl(double x1, double y1, double x2, double y2, double x3, double y3, double x4, double y4) {
>                         super(x1, y1, x2, y2, x3, y3, x4, y4);
>                 }
>                 public Rectangle2D getBounds2D() {
>                         return null;
>                 }
>         }
> ========= RI Output =========
> obj.contains=false
> ======== Harmony output =====
> java.lang.NullPointerException
>     at org.apache.harmony.awt.gl.Crossing.crossShape(Crossing.java:506)
>     at java.awt.geom.CubicCurve2D.contains(CubicCurve2D.java:537)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira