Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <13001159.1158668783926.JavaMail.jira@brutus>
Date: Tue, 19 Sep 2006 05:26:23 -0700 (PDT)
From: "Artem Aliev (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-1340) Fix invalid assertion in
 thread_native_fat_monitor.c
In-Reply-To: <6119557.1156870703483.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-1340?page=comments#action_12435767 ] 
            
Artem Aliev commented on HARMONY-1340:
--------------------------------------

The assertion in the current code is incorrect, it check that monitor is entered not more then once (recursion_count < 1)
It was left in the code by mistake.
The monitor recursion count could be any positive number  (the number of nested monitorEnter calls).
So the fix is correct.


> Fix invalid assertion in thread_native_fat_monitor.c
> ----------------------------------------------------
>
>                 Key: HARMONY-1340
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1340
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: Windows XP professional
>            Reporter: Anton Luht
>         Assigned To: weldon washburn
>         Attachments: patch.txt
>
>
> java version "1.5.0"
> pre-alpha : not complete or compatible
> svn = r438091, (Aug 29 2006), Windows/ia32/msvc 1310, debug build
> http://incubator.apache.org/harmony
> An attempt to run 'ant test' to run tests causes a popup notifying about an assertion failure in thread_native_fat_monitor.c line 183: saved_recursion < 1
> Seems like assertion saved_recursion >= 0 is more appropriate here
> at least with this assertion popup disappears and build proceeds
> Please see the patch attached

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira