harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gregory Shimansky (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1490) [drlvm] Fixes for SingleStep implementation. Corrected phase, state structure, addded m2n transition
Date Thu, 21 Sep 2006 00:14:23 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1490?page=comments#action_12436407 ] 
            
Gregory Shimansky commented on HARMONY-1490:
--------------------------------------------

It looks like incorrect status of inkage of issues, this patch actually blocks HARMONY-1507
because Pavel has significantly changed the code of this patch in his issue.

The bugfixes he's pointed out are valid and I agree with them. The work is in progress and
even attached simple single step test still gives the problems. I don't want to change the
patch in this issue because I don't want to create conflicts with HARMONY-1507. I've already
integrated Pavel's fixes and am going to work on them in further development.

> [drlvm] Fixes for SingleStep implementation. Corrected phase, state structure, addded
m2n transition
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1490
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1490
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>            Reporter: Gregory Shimansky
>         Attachments: single-step-fixes.patch, test.zip
>
>
> I've created several bugfixes for SingleStep event implementation.
> It appears that keeping enabled flag in JVMTISingleStepState struct is not possible because
it may be deallocated when thread finishes. So I decided that enabled flag should be the pointer
to this struct itself.
> Another bugfix is that SingleStep shouldn't be sent in phases other than LIVE. This also
fixes the problem when SingleStep is sent for VM startup and agent cannot use any JNI function
yet.
> Another bugfix is for breakpoint. For JIT mode I've added an m2n transition to allow
stack iterator to work correctly inside of breakpoint callback. Otherwise it didn't see the
upper Java frames.
> On windows the test I am using still crashes when it finishes, but at least I can see
SingleStep events coming to the agent.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message