harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1408) [classlib][beans] implementation of ProxyPersistenceDelegate
Date Mon, 11 Sep 2006 06:44:23 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1408?page=comments#action_12433782 ] 
Alexey Varlamov commented on HARMONY-1408:

Just a minor notice:
this check:
+                    // process only if the class differs from Class itself
+                    if (!((Class) target).getName().equals("java.lang.Class")) {
better replace with:
+                    // process only if the class differs from Class itself
+                    if (target != Class.class) {
The latter expression is more correct (invulnerable to name spooffing in custom classloader)
and is much faster.

> [classlib][beans] implementation of ProxyPersistenceDelegate
> ------------------------------------------------------------
>                 Key: HARMONY-1408
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1408
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: ws2003
>            Reporter: Alexei Zakharov
>         Attachments: CustomizedPDTest4.patch
> The attached patch contains implementation of persistence delegate for all dynamic proxy
objects that can be created by means of the java.lang.reflect.Proxy class methods. In the
process of development of this persistence delegate a few bugs in Statement and DefaultPersistenceDelegatesFactory
were also fixed. After applying this patch all tests from org.apache.harmony.beans.tests.java.beans.CustomizedPersistenceDelegateTest
will be enabled so we can remove this class from the exclude list.
> Thanks, Alexei

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message