harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Nathan Beyer (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1481) [classlib][sound] Class MidiSystem and some utils
Date Mon, 18 Sep 2006 02:24:23 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1481?page=comments#action_12435368 ] 
            
Nathan Beyer commented on HARMONY-1481:
---------------------------------------

Here are few comments about this patch that I'd like to see resolved before moving ahead.

1. Consider using generics in the ProviderService classes methods. For example, the getProviders
method could using this signature instead: public static List<? extends MidiDeviceProvider>
getProviders(String providerName).

2. MidiSystem contains some thread races. Specifically, the code is checking the static fields
for null and then doing a lookup of the providers and assigning the fields. This code either
needs synchronization to protect these fields properly or the static fields should just be
eliminated altogether. I would suggest the just eliminating the static fields altogether.
This will make the code more simple and straightforward; optimizations can always be made
later.

> [classlib][sound] Class MidiSystem and some utils
> -------------------------------------------------
>
>                 Key: HARMONY-1481
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1481
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Evgeny S. Sidorenko
>         Assigned To: Nathan Beyer
>         Attachments: MidiSystem.patch.txt, org.apache.harmony.sound.utils.patch.txt
>
>
> Patch MidiSystem.patch.txt contains realization of class MidiSystem.
> Patch org.apache.harmony.sound.utils.patch.txt contains some utilities that helps to
works with classes MidiSystem and AudioSystem
> For this time this patch doesn't support internationalization

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message