harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexey Varlamov (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1519) [DRLVM] Performance degradation while working in Eclipse
Date Tue, 26 Sep 2006 06:06:52 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1519?page=comments#action_12437748 ] 
            
Alexey Varlamov commented on HARMONY-1519:
------------------------------------------

Artem, I like the new patch; it does not look like workaround anymore ;)
Just minor comments, in the function _thread_cond_timedwait():

85: unused variable struct waiting_node *tmp;

95-103:    Getting apr_get_os_error() is a bit late, error status is likely to be reset after
apr_thread_mutex_lock() .

    res = WaitForSingleObject(node.event, timeout_ms);
    apr_thread_mutex_lock(mutex);
       if (res != WAIT_OBJECT_0) {
            if (res == WAIT_TIMEOUT) {
                rv = APR_TIMEUP;
            } else {
               rv = apr_get_os_error();
            }
        }

104 - 107:     CloseHandle() better be called after UNLOCK_QUEUE
    LOCK_QUEUE;
    _remove_from_queue (cond, &node);
    CloseHandle(node.event);
    UNLOCK_QUEUE;

> [DRLVM] Performance degradation while working in Eclipse
> --------------------------------------------------------
>
>                 Key: HARMONY-1519
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1519
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: 2xXeon CPU, Windows 2003 Server SP1
>            Reporter: Alexey Varlamov
>            Priority: Critical
>         Attachments: apr_cond.patch, new_queued_cond_var.patch
>
>
> The DRLVM sometimes become VERY slow during Eclipse session, it almost freezes whole
system consuming 99% CPU.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message