harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elena Semukhina (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1625) [drlvm] ThreadGroupTest of classlib fails
Date Fri, 29 Sep 2006 12:10:51 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1625?page=comments#action_12438699 ] 
            
Elena Semukhina commented on HARMONY-1625:
------------------------------------------

1) test_setMaxPriorityI 
The spec for ThreadGroup.setMaxPriority() says:
If the pri argument is less than Thread.MIN_PRIORITY, the maximum priority of the group remains
unchanged. 
The test expects that maximum priority of the group is set to Thread.MIN_PRIORITY. This is
a bug in RI and here is a link to the issue report:
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4708197

I suggest to change the test so that it corresponds to spec. 

2) test_suspend fails because it tries to destroy a non-empty group containing suspended threads.
I suggest to change the test so that it stops the threads and then destroys the group.

3) test_list fails because it verifies the length of the output string. The output on drlvm
is quite correct but longer than expected. I suggest to change the test so that it checks
the output in more smart way. 
NOTE: the test fails now on the current drlvm build due to errors in launcher implementation
and should pass after HARMONY-1582 is committed. 


> [drlvm] ThreadGroupTest of classlib fails
> -----------------------------------------
>
>                 Key: HARMONY-1625
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1625
>             Project: Harmony
>          Issue Type: Bug
>          Components: DRLVM
>         Environment: Linux IA32 multiprocessor
>            Reporter: Alexey Varlamov
>
> The org.apache.harmony.luni.tests.java.lang.ThreadGroupTest stably fails if run individually:
> 1)  <testcase classname="org.apache.harmony.luni.tests.java.lang.ThreadGroupTest"
name="test_setMaxPriorityI" time="0.053">
>     <failure message="setMaxPriority: Any value smaller than MIN_PRIORITY is adjusted
to MIN_PRIORITY. Before: 10 , after: 10" type="junit.framework.AssertionFailedError">junit.framework.AssertionFailedError:
setMaxPriority: Any value smaller than MIN_PRIORITY is adjusted to MIN_PRIORITY. Before: 10
, after: 10
> 	at junit.framework.AssertionFailedError.&lt;init&gt;(AssertionFailedError.java:11)
> 	at org.apache.harmony.luni.tests.java.lang.ThreadGroupTest.test_setMaxPriorityI(ThreadGroupTest.java:648)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 2)  <testcase classname="org.apache.harmony.luni.tests.java.lang.ThreadGroupTest"
name="test_suspend" time="3.86">
>     <error message="The thread group Test group is not empty" type="java.lang.IllegalThreadStateException">java.lang.IllegalThreadStateException:
The thread group Test group is not empty
> 	at java.lang.ThreadGroup.destroy(Unknown Source)
> 	at org.apache.harmony.luni.tests.java.lang.ThreadGroupTest.test_suspend(ThreadGroupTest.java:856)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> 3)   <testcase classname="org.apache.harmony.luni.tests.java.lang.ThreadGroupTest"
name="test_list" time="0.213">
>       <failure message="Either &apos;list&apos; is wrong or other tests are
leaving side-effects. Result from list:  -----------------  java.lang.ThreadGroup[name=system,maxpri=10]
    Thread[Thread-1,5,system]     Thread[Thread-0,5,system]     Thread[System thread,5,system]
    java.lang.ThreadGroup[name=Finalizer Threads Group,maxpri=10]         Thread[FinalizerThread,5,Finalizer
Threads Group]     java.lang.ThreadGroup[name=activeCount,maxpri=10]     java.lang.ThreadGroup[name=Test
group,maxpri=10]  -----------------  " type="junit.framework.AssertionFailedError">junit.framework.AssertionFailedError:
Either &apos;list&apos; is wrong or other tests are leaving side-effects.
> Result from list:
>  -----------------
>  java.lang.ThreadGroup[name=system,maxpri=10]
>     Thread[Thread-1,5,system]
>     Thread[Thread-0,5,system]
>     Thread[System thread,5,system]
>     java.lang.ThreadGroup[name=Finalizer Threads Group,maxpri=10]
>         Thread[FinalizerThread,5,Finalizer Threads Group]
>     java.lang.ThreadGroup[name=activeCount,maxpri=10]
>     java.lang.ThreadGroup[name=Test group,maxpri=10]
> -----------------
>  
> 	at org.apache.harmony.luni.tests.java.lang.ThreadGroupTest.test_list(ThreadGroupTest.java:481)
> 	at java.lang.reflect.VMReflection.invokeMethod(Native Method)
> This test sporadically crashes when all luni tests are run, but that is probably another
story.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message