Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <30600685.1154448615309.JavaMail.jira@brutus>
Date: Tue, 1 Aug 2006 09:10:15 -0700 (PDT)
From: "Alexei Zakharov (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Updated: (HARMONY-975) [classlib][beans] fixes for
 DefaultPersistenceDelegateTest failures (1)
In-Reply-To: <29032437.1153844774025.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

     [ http://issues.apache.org/jira/browse/HARMONY-975?page=all ]

Alexei Zakharov updated HARMONY-975:
------------------------------------

    Attachment: DefailtPersistenceDelegateTest2.patch

Stepan, please see the new patch attached. It enables all tests mentioned above on our implementation (no corrections in tests). However, testInstantiate_EmptyProperty still fails on the RI. It seems the behaviour of our Introspector differs from RI's Introspector. I think I will create a separate JIRA for that. Thanks. 

> [classlib][beans] fixes for DefaultPersistenceDelegateTest failures (1)
> -----------------------------------------------------------------------
>
>                 Key: HARMONY-975
>                 URL: http://issues.apache.org/jira/browse/HARMONY-975
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>         Environment: winXP
>            Reporter: Alexei Zakharov
>         Attachments: DefailtPersistenceDelegateTest.patch, DefailtPersistenceDelegateTest2.patch
>
>
> Currently 19 tests from org.apache.harmony.beans.tests.java.beans.DefaultPersistenceDelegateTest class fail due various reasons. The attached patch corrects some of these failures. Please see the list of affected tests below.
> testInstantiate_NullProperty
> testInstantiate_EmptyProperty
> testInstantiate_NonExistingGetterNullEncoder
> Invalid tests indeed. Fail if NullPointerException isn't thrown. Neither RI nor our implementation throws such exception here. Corrected. 
> testInstantiate_NonExistingGetter
> testInstantiate_NoGetter
> Are also invalid tests. They test the behavior that is specific to some third-party implementation of beans (not RI). I corrected the sophisticated but invalid exception handling I've found in these tests. Now it reflects the RI behavior. Please note that using of singleton class CallVerificationStack is thread unsafe here. I have replaced CallVerificationStack with locally defined variable.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira