Return-Path: Delivered-To: apmail-incubator-harmony-commits-archive@www.apache.org Received: (qmail 78366 invoked from network); 4 Aug 2006 08:51:45 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur.apache.org with SMTP; 4 Aug 2006 08:51:45 -0000 Received: (qmail 54132 invoked by uid 500); 4 Aug 2006 08:51:45 -0000 Delivered-To: apmail-incubator-harmony-commits-archive@incubator.apache.org Received: (qmail 54037 invoked by uid 500); 4 Aug 2006 08:51:44 -0000 Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: harmony-dev@incubator.apache.org Delivered-To: mailing list harmony-commits@incubator.apache.org Received: (qmail 54026 invoked by uid 99); 4 Aug 2006 08:51:44 -0000 Received: from asf.osuosl.org (HELO asf.osuosl.org) (140.211.166.49) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2006 01:51:44 -0700 X-ASF-Spam-Status: No, hits=-9.4 required=10.0 tests=ALL_TRUSTED,NO_REAL_NAME X-Spam-Check-By: apache.org Received-SPF: pass (asf.osuosl.org: local policy) Received: from [140.211.166.113] (HELO eris.apache.org) (140.211.166.113) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 04 Aug 2006 01:51:43 -0700 Received: by eris.apache.org (Postfix, from userid 65534) id DC3171A981C; Fri, 4 Aug 2006 01:51:23 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r428668 - in /incubator/harmony/enhanced/classlib/trunk/modules/beans/src: main/java/java/beans/Expression.java test/java/org/apache/harmony/beans/tests/java/beans/ExpressionTest.java Date: Fri, 04 Aug 2006 08:51:23 -0000 To: harmony-commits@incubator.apache.org From: mloenko@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20060804085123.DC3171A981C@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org X-Spam-Rating: minotaur.apache.org 1.6.2 0/1000/N Author: mloenko Date: Fri Aug 4 01:51:22 2006 New Revision: 428668 URL: http://svn.apache.org/viewvc?rev=428668&view=rev Log: applied patch for HARMONY-1061 [classlib][beans] tests from ExpressionTest fail on RI Modified: incubator/harmony/enhanced/classlib/trunk/modules/beans/src/main/java/java/beans/Expression.java incubator/harmony/enhanced/classlib/trunk/modules/beans/src/test/java/org/apache/harmony/beans/tests/java/beans/ExpressionTest.java Modified: incubator/harmony/enhanced/classlib/trunk/modules/beans/src/main/java/java/beans/Expression.java URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/beans/src/main/java/java/beans/Expression.java?rev=428668&r1=428667&r2=428668&view=diff ============================================================================== --- incubator/harmony/enhanced/classlib/trunk/modules/beans/src/main/java/java/beans/Expression.java (original) +++ incubator/harmony/enhanced/classlib/trunk/modules/beans/src/main/java/java/beans/Expression.java Fri Aug 4 01:51:22 2006 @@ -57,10 +57,21 @@ */ public String toString() { try { - Object resultValue = getValue(); - String result = (resultValue == null) ? "" - : convertClassName(resultValue.getClass()); - return result + "=" + super.toString(); + StringBuilder sb = new StringBuilder(); + + if (!valueIsDefined) { + sb.append(""); + } else { + if (value == null) { + sb.append("null"); + } else { + sb.append(convertClassName(value.getClass())); + } + } + sb.append('='); + sb.append(super.toString()); + + return sb.toString(); } catch(Exception e) { return new String("Error in expression: " + e.getClass()); } Modified: incubator/harmony/enhanced/classlib/trunk/modules/beans/src/test/java/org/apache/harmony/beans/tests/java/beans/ExpressionTest.java URL: http://svn.apache.org/viewvc/incubator/harmony/enhanced/classlib/trunk/modules/beans/src/test/java/org/apache/harmony/beans/tests/java/beans/ExpressionTest.java?rev=428668&r1=428667&r2=428668&view=diff ============================================================================== --- incubator/harmony/enhanced/classlib/trunk/modules/beans/src/test/java/org/apache/harmony/beans/tests/java/beans/ExpressionTest.java (original) +++ incubator/harmony/enhanced/classlib/trunk/modules/beans/src/test/java/org/apache/harmony/beans/tests/java/beans/ExpressionTest.java Fri Aug 4 01:51:22 2006 @@ -115,7 +115,7 @@ assertSame(arg3, t.getArguments()[2]); assertSame(arg4, t.getArguments()[3]); - assertEquals("String=ExpressionTest$MockParent.method(" + + assertEquals("=ExpressionTest$MockParent.method(" + "\"string1\", Object, \"string3\", Integer);", t.toString()); } @@ -147,7 +147,7 @@ assertSame(oa, t.getArguments()); assertSame(arg, t.getArguments()[0]); - assertEquals("String=ExpressionTest$MockParent.method(Object);", + assertEquals("=ExpressionTest$MockParent.method(Object);", t.toString()); } @@ -176,7 +176,7 @@ assertSame("new", t.getMethodName()); assertSame(oa, t.getArguments()); - assertEquals("ExpressionTest$MockObject=Class.new(Object);", + assertEquals("=Class.new(Object);", t.toString()); } @@ -204,7 +204,7 @@ assertSame("method", t.getMethodName()); assertEquals(0, t.getArguments().length); - assertEquals("String=ExpressionTest$MockParent.method();", + assertEquals("=ExpressionTest$MockParent.method();", t.toString()); } @@ -221,7 +221,7 @@ assertSame(oa, t.getArguments()); assertNull(t.getArguments()[0]); - assertEquals("String=ExpressionTest$MockParent.method(null);", + assertEquals("=ExpressionTest$MockParent.method(null);", t.toString()); } @@ -387,7 +387,7 @@ assertSame(oa, t.getArguments()); assertNull(t.getArguments()[0]); - assertEquals("=Object.method(null);", t.toString()); + assertEquals("null=Object.method(null);", t.toString()); } /* @@ -776,8 +776,8 @@ MockObject mo = new MockObject(false); Object[] arguments = new Object[] { new Integer(1) }; Expression t = new Expression(mo, "methodB", arguments); - assertEquals("methodB1", t.getValue()); - MockObject.assertCalled("methodB1", arguments); + assertEquals("methodB2", t.getValue()); + MockObject.assertCalled("methodB2", arguments); arguments = new Object[] { Boolean.FALSE }; t = new Expression(mo, "methodB", arguments); @@ -835,14 +835,14 @@ * * Note: decided by definition position! should be ambiguous. */ - public void testGetValue_EqualSpecificMethods() throws Exception { - MockObject mo = new MockObject(false); - Object[] arguments = new Object[] { new MockObject(false), - new MockObject(false) }; - Expression t = new Expression(mo, "equalSpecificMethod", arguments); - assertEquals("equalSpecificMethod1", t.getValue()); - MockObject.assertCalled("equalSpecificMethod1", arguments); - } +// public void testGetValue_EqualSpecificMethods() throws Exception { +// MockObject mo = new MockObject(false); +// Object[] arguments = new Object[] { new MockObject(false), +// new MockObject(false) }; +// Expression t = new Expression(mo, "equalSpecificMethod", arguments); +// assertEquals("equalSpecificMethod1", t.getValue()); +// MockObject.assertCalled("equalSpecificMethod1", arguments); +// } /* * Test the method getValue() with two equal specific methods but one @@ -850,14 +850,14 @@ * * Note: decided by definition position! should call the one with exception. */ - public void testGetValue_EqualSpecificMethodsException() throws Exception { - MockObject mo = new MockObject(false); - Object[] arguments = new Object[] { new MockObject(false), - new MockObject(false), new Object() }; - Expression t = new Expression(mo, "equalSpecificMethod", arguments); - assertEquals("equalSpecificMethod3", t.getValue()); - MockObject.assertCalled("equalSpecificMethod3", arguments); - } +// public void testGetValue_EqualSpecificMethodsException() throws Exception { +// MockObject mo = new MockObject(false); +// Object[] arguments = new Object[] { new MockObject(false), +// new MockObject(false), new Object() }; +// Expression t = new Expression(mo, "equalSpecificMethod", arguments); +// assertEquals("equalSpecificMethod3", t.getValue()); +// MockObject.assertCalled("equalSpecificMethod3", arguments); +// } /* * Super class of MockObject. @@ -969,12 +969,12 @@ throw new NullPointerException(); } - public Object methodB(Integer i) { - reset(); - calledMethod = "methodB1"; - receivedArguments.add(i); - return calledMethod; - } +// public Object methodB(Integer i) { +// reset(); +// calledMethod = "methodB1"; +// receivedArguments.add(i); +// return calledMethod; +// } public Object methodB(int i) { reset(); @@ -1017,40 +1017,40 @@ return calledMethod; } - public Object equalSpecificMethod(MockObject o, MockParent p) { - reset(); - calledMethod = "equalSpecificMethod1"; - receivedArguments.add(o); - receivedArguments.add(p); - return calledMethod; - } - - public Object equalSpecificMethod(MockParent p, MockObject o) { - reset(); - calledMethod = "equalSpecificMethod2"; - receivedArguments.add(p); - receivedArguments.add(o); - return calledMethod; - } - - public Object equalSpecificMethod(MockObject o, MockParent p, Object o2) { - reset(); - calledMethod = "equalSpecificMethod3"; - receivedArguments.add(o); - receivedArguments.add(p); - receivedArguments.add(o2); - return calledMethod; - } - - public Object equalSpecificMethod(MockParent p, MockObject o, Object o2) - throws Exception { - reset(); - calledMethod = "equalSpecificMethod4"; - receivedArguments.add(p); - receivedArguments.add(o); - receivedArguments.add(o2); - return calledMethod; - } +// public Object equalSpecificMethod(MockObject o, MockParent p) { +// reset(); +// calledMethod = "equalSpecificMethod1"; +// receivedArguments.add(o); +// receivedArguments.add(p); +// return calledMethod; +// } + +// public Object equalSpecificMethod(MockParent p, MockObject o) { +// reset(); +// calledMethod = "equalSpecificMethod2"; +// receivedArguments.add(p); +// receivedArguments.add(o); +// return calledMethod; +// } + +// public Object equalSpecificMethod(MockObject o, MockParent p, Object o2) { +// reset(); +// calledMethod = "equalSpecificMethod3"; +// receivedArguments.add(o); +// receivedArguments.add(p); +// receivedArguments.add(o2); +// return calledMethod; +// } + +// public Object equalSpecificMethod(MockParent p, MockObject o, Object o2) +// throws Exception { +// reset(); +// calledMethod = "equalSpecificMethod4"; +// receivedArguments.add(p); +// receivedArguments.add(o); +// receivedArguments.add(o2); +// return calledMethod; +// } public static Class forName(String o) { reset();