Mailing-List: contact harmony-commits-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: harmony-dev@incubator.apache.org
Message-ID: <10325022.1155712334820.JavaMail.jira@brutus>
Date: Wed, 16 Aug 2006 00:12:14 -0700 (PDT)
From: "Andrew Zhang (JIRA)" <jira@apache.org>
To: harmony-commits@incubator.apache.org
Subject: [jira] Commented: (HARMONY-1206) [classlib][luni] Remove a never
 used variable "MulticastSocketTest" in
 tests.api.java.net.MulticastSocketTest.
In-Reply-To: <25216935.1155711973878.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

    [ http://issues.apache.org/jira/browse/HARMONY-1206?page=comments#action_12428343 ] 
            
Andrew Zhang commented on HARMONY-1206:
---------------------------------------

Ah... Sorry for my type mistake in the JIRA subject. I mean "sameAsNetworkInterface1", not "MulticastSocketTest".

Thanks!

Best regards,
Andrew

> [classlib][luni] Remove a never used variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest.
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1206
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1206
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>            Reporter: Andrew Zhang
>            Priority: Minor
>         Attachments: Harmony-1206.diff
>
>
> Remove class variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest, which is never used in test and may cause unnecessary failures.
> Consider following code in setUp():
> if (addresses != null) {
> 	try {
> 	    sameAsNetworkInterface1 = NetworkInterface.getByInetAddress((InetAddress) addresses.nextElement()); 
> 	} catch (SocketException e) {
> 	}
> }
> Notice that addresses.nextElement() may throw exception if addresses is empty (but not null). 
> I'll upload a patch to remove these unnecessary code soon.
> Thanks!
> Best regards,
> Andrew

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira