harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulex Yang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1051) [classlib][nio_char] Use system classloader as an alternative to load charset provider classes when thread's context classloader fails to load them.
Date Tue, 15 Aug 2006 07:33:15 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1051?page=comments#action_12428052 ] 
            
Paulex Yang commented on HARMONY-1051:
--------------------------------------

Andrew, I have some concern on this patch:
1. It has no regression test, I knew this regression may be a little complex, but it's still
possible to mock a thread context loader to test the exceptional case.
2. The static field contextClassLoader is not thread safe,while the spec of Charset require
the thread safety. 

So would you please provide another patch for this? any problem, please let me know, thank
you.

> [classlib][nio_char] Use system classloader as an alternative to load charset provider
classes when thread's context classloader fails to load them.
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1051
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1051
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Andrew Zhang
>         Assigned To: Paulex Yang
>         Attachments: Harmony-1051.diff
>
>
> As we dicussed on the mailing list[1],  using system classloader as an alternative to
load charset provider classes when thread's context classloader fails to load them will be
a good choice to follow RI while keeping compliant with spec.
> I'll upload a patch for this improvement soon.
> Thanks!
> Best regards,
> Andrew
> [1] mailing list thread: [classlib][nio-charset] RI is inconsistent with spec when loading
charset provider

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message