harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paulex Yang (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HARMONY-1150) [classlib][instrument]Harmony lacks of default implementation for java.lang.instrument.Instrumentation
Date Fri, 11 Aug 2006 10:19:15 GMT
     [ http://issues.apache.org/jira/browse/HARMONY-1150?page=all ]

Paulex Yang resolved HARMONY-1150.
----------------------------------

    Resolution: Fixed

Jimmy, patch applied at revision r430751, thanks a lot for this enhancement, please verify
that the problem is fully fixed as you expected.

Though I found some potential issues of this patch, say, the error code definition is magic
number, so if JVMTI change the error code value, the codes will break. And further, the executePremain
method uses default encoding to parse the class name, I think it is dangerous. I'm expecting
your further enhancement on this. thank you.


> [classlib][instrument]Harmony lacks of default implementation for java.lang.instrument.Instrumentation
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-1150
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1150
>             Project: Harmony
>          Issue Type: Improvement
>          Components: Classlib
>            Reporter: Jimmy, Jing Lv
>         Assigned To: Paulex Yang
>         Attachments: instrument.zip
>
>
> Hi,
>     The default implementation for java.lang.instrument.Instrumentation should be added
as internal class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message