harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Khaschansky (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HARMONY-1101) [classlib][archive] unexpected IOException for double ZipInputStream().close()
Date Tue, 08 Aug 2006 12:03:15 GMT
    [ http://issues.apache.org/jira/browse/HARMONY-1101?page=comments#action_12426543 ] 
            
Oleg Khaschansky commented on HARMONY-1101:
-------------------------------------------

Sorry, not updated before uploading patch.

> [classlib][archive] unexpected IOException for double ZipInputStream().close()
> ------------------------------------------------------------------------------
>
>                 Key: HARMONY-1101
>                 URL: http://issues.apache.org/jira/browse/HARMONY-1101
>             Project: Harmony
>          Issue Type: Bug
>          Components: Classlib
>            Reporter: Vladimir Ivanov
>         Attachments: harmony-1101.patch, ZipInputStream.patch
>
>
> The spec says for the method java.io.Closeable.close(): "If the stream is already closed
then invoking this method has no effect".
> The spec for java.util.zip.ZipInputStream.close() says nothing for double call but RI
follow the spec for Closeable and do nothing while Harmony throws IOException.
> ====================== test.java ======================
> import java.io.*; 
> import java.util.zip.*; 
> public class test { 
>     public static void main(String args[]) { 
>         ZipInputStream zis = null; 
>         try { 
>             File f=new File("myFile"); 
>             f.createNewFile(); 
>             f.deleteOnExit(); 
>             BufferedInputStream b = new BufferedInputStream(new FileInputStream(f));

>             zis = new ZipInputStream(new BufferedInputStream(b)); 
>         } catch (IOException e) { 
>             System.out.println("unexpected exception: " + e);
>             return;
>         } 
>         try {
>             if (zis != null) { 
>                 zis.close(); 
>                 zis.close();
>             }
>             System.out.println("PASSED"); 
>         } catch (IOException e) { 
>             System.out.println("FAILED: " + e); 
>             e.printStackTrace();
>         } 
>     } 
> } 
> ====================================================
> Output:
> C:\tmp\tmp17>C:\jrockit-jdk1.5.0-windows-ia32\bin\java.exe -cp . -showversion test
> java version "1.5.0"
> Java(TM) 2 Runtime Environment, Standard Edition (build 1.5.0-b64)
> BEA WebLogic JRockit(R) (build dra-38972-20041208-2001-win-ia32, R25.0.0-75, GC: System
optimized over throughput (initial strategy singleparpar))
> PASSED
> C:\tmp\tmp17>C:\harmony\trunk_0427\deploy\jdk\jre\bin\java.exe -cp . -showversion
test
> java version 1.5 (subset)
> (c) Copyright 1991, 2006 The Apache Software Foundation or its licensors, as applicable.
> FAILED: java.io.IOException: Stream is closed
> java.io.IOException: Stream is closed
>         at java.util.zip.ZipInputStream.closeEntry(ZipInputStream.java:90)
>         at java.util.zip.ZipInputStream.close(ZipInputStream.java:80)
>         at test.main(test.java:20)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message