harmony-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Zhang (JIRA)" <j...@apache.org>
Subject [jira] Created: (HARMONY-1206) [classlib][luni] Remove a never used variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest.
Date Wed, 16 Aug 2006 07:06:13 GMT
[classlib][luni] Remove a never used variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest.

                 Key: HARMONY-1206
                 URL: http://issues.apache.org/jira/browse/HARMONY-1206
             Project: Harmony
          Issue Type: Test
          Components: Classlib
            Reporter: Andrew Zhang
            Priority: Minor

Remove class variable "MulticastSocketTest" in tests.api.java.net.MulticastSocketTest, which
is never used in test and may cause unnecessary failures.
Consider following code in setUp():
if (addresses != null) {
	try {
	    sameAsNetworkInterface1 = NetworkInterface.getByInetAddress((InetAddress) addresses.nextElement());

	} catch (SocketException e) {

Notice that addresses.nextElement() may throw exception if addresses is empty (but not null).

I'll upload a patch to remove these unnecessary code soon.

Best regards,

This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message